Re: Failure to build www/firefox

[Thomas Klausner <tk%giga.or.at@localhost>]

On Fri, May 08, 2020 at 09:53:10AM +0200, Thomas Klausner wrote:
> On Fri, May 08, 2020 at 07:46:28AM +0000, maya%NetBSD.org@localhost wrote:
> > On Fri, May 08, 2020 at 07:41:06AM +0200, Thomas Klausner wrote:
> > > On Thu, May 07, 2020 at 09:06:12PM +0200, Martin Husemann wrote:
> > > > On Thu, May 07, 2020 at 07:55:20PM +0100, Mike Pumford wrote:
> > > > > Just found this change to clang10 in the right timeframe that looks like it
> > > > > might impact which libstdc++ we are getting:
> > > > > 
> > > > > http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/clang/Makefile.common.diff?r1=1.42&r2=1.43&only_with_tag=MAIN
> > > > > 
> > > > > Just kicked off a build with that change backed out and see if it helps.
> > > > 
> > > > I can tell you without waiting for the build results:
> > > > 
> > > > with r1.42 I get SUBST_CLASES libcxx cmake, with r1.42 it is only cmake.
> > > > 
> > > > This change is broken and we need to rebuild clang as well.
> > > 
> > > Even with the fixed clang, I still see:
> > > 
> > > cargo:warning=/scratch/www/firefox/work/build/dist/include/mozilla/Assertions.h:425:23: error: no template named 'is_array_v' in namespace 'std';
> > > did you mean 'is_array'?
> > > cargo:warning=  static_assert(!std::is_array_v<ValueT>,
> > > cargo:warning=                 ~~~~~^~~~~~~~~~
> > > cargo:warning=                      is_array
> > 
> > This seems to be a c++17 thing.
> > 
> > I wonder if we need to drop our own USE_LANGUAGES=c++14 to c++ and
> > leave upstream to choose correct values for every file.
> 
> Actually I pasted the wrong log. That was one of the build failures from before.
> It failed, I'm currently retrying to see what the issue was, I couldn't tell from the log.

This is my current failure mode:

gmake[3]: Entering directory '/scratch/www/firefox/work/build/widget/gtk/mozwayland'
gmake[3]: Nothing to be done for 'target'.
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/widget/gtk/mozwayland'
gmake[3]: Entering directory '/scratch/www/firefox/work/build/media/ffvpx/libavcodec'
gmake[3]: Nothing to be done for 'target'.
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/media/ffvpx/libavcodec'
toolkit/library/buildid.o
/scratch/www/firefox/work/.cwrapper/bin/c++ -std=gnu++17 -o buildid.o -c  -I/scratch/www/firefox/work/build/dist/stl_wrappers -I/scratch/www/firefox/work/build/dist/system_wrappers -include /scratch/www/firefox/work/firefox-76.0/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/scratch/www/firefox/work/firefox-76.0/toolkit/library -I/scratch/www/firefox/work/build/toolkit/library -I/scratch/www/firefox/work/firefox-76.0/config -I/scratch/www/firefox/work/firefox-76.0/widget/windows -I/scratch/www/firefox/work/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/scratch/www/firefox/work/build/dist/include/nss -I/usr/X11R7/include/pixman-1 -fPIC -DPIC -DMOZILLA_CLIENT -include /scratch/www/firefox/work/build/mozilla-config.h -Qunused-arguments -g -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -O2 -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -g -D_FORTIFY_SOURCE=2 -fstack-check -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables -fexperimental-new-pass-manager  -MD -MP -MF .deps/buildid.o.pp   buildid.cpp
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/toolkit/library/rust'
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/toolkit/library'
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/browser/app'
gmake[3]: Entering directory '/scratch/www/firefox/work/build/browser/app'
browser/app/firefox
/scratch/www/firefox/work/.cwrapper/bin/c++ -std=gnu++17 -o ../../dist/bin/firefox -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -g -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -O2 -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -g -D_FORTIFY_SOURCE=2 -fstack-check -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables  /scratch/www/firefox/work/build/browser/app/firefox.list    -lpthread -Wl,-R/usr/pkg/lib/firefox -Wl,-R/usr/pkg/lib -Wl,-z,relro -Wl,-z,now -L/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -L/usr/pkg/lib/nspr -Wl,-R/usr/pkg/lib/nspr -L/usr/pkg/lib/nss -Wl,-R/usr/pkg/lib/nss -L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib -L/usr/pkg/lib/ffmpeg4 -Wl,-R/usr/pkg/lib/ffmpeg4 -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 -fstack-protector-strong -rdynamic -Wl,-rpath-link,/scratch/www/firefox/work/build/dist/bin -Wl,-rpath-link,/usr/pkg/lib    -Wl,--export-dynamic -pie
/scratch/www/firefox/work/build/_virtualenvs/init_py3/bin/python -m mozbuild.action.check_binary --target ../../dist/bin/firefox
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/browser/app'
gmake[3]: *** [/scratch/www/firefox/work/firefox-76.0/config/rules.mk:752: Unified_cpp_layout_style4.o] Segmentation fault (core dumped)
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/layout/style'
gmake[2]: *** [/scratch/www/firefox/work/firefox-76.0/config/recurse.mk:74: layout/style/target-objects] Error 2
gmake[2]: *** Waiting for unfinished jobs....
gmake[3]: *** [/scratch/www/firefox/work/firefox-76.0/config/rules.mk:752: Unified_cpp_layout_generic3.o] Segmentation fault (core dumped)
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/layout/generic'
gmake[2]: *** [/scratch/www/firefox/work/firefox-76.0/config/recurse.mk:74: layout/generic/target-objects] Error 2
gmake[3]: *** [/scratch/www/firefox/work/firefox-76.0/config/rules.mk:752: Unified_cpp_layout_painting0.o] Segmentation fault (core dumped)
gmake[3]: Leaving directory '/scratch/www/firefox/work/build/layout/painting'
gmake[2]: *** [/scratch/www/firefox/work/firefox-76.0/config/recurse.mk:74: layout/painting/target-objects] Error 2
gmake[2]: Leaving directory '/scratch/www/firefox/work/build'
gmake[1]: *** [/scratch/www/firefox/work/firefox-76.0/config/recurse.mk:34: compile] Error 2
gmake[1]: Leaving directory '/scratch/www/firefox/work/build'
gmake: *** [/scratch/www/firefox/work/firefox-76.0/config/rules.mk:394: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/www/firefox
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/www/firefox
#

 Thomas