Re: firefox fails to build on netbsd-8 amd64

[maya%NetBSD.org@localhost]

On Mon, Jun 22, 2020 at 06:16:47PM +0000, maya%NetBSD.org@localhost wrote:
> On Mon, Jun 22, 2020 at 04:42:35PM +0000, nia wrote:
> > On Mon, Jun 22, 2020 at 12:00:55PM -0400, Greg Troxel wrote:
> > > nia <nia%NetBSD.org@localhost> writes:
> > > 
> > > > BUILDLINK_API_DEPENDS.MesaLib+=	MesaLib>=17.2.0
> > > 
> > > OK to commit that?
> > 
> > I'd wait until you actually get a finished build, it might cause
> > unfortunate conflicts with gtk3 linking against an older version,
> > or something.
> > 
> > > 
> > > Things get further now, failing at with the following:
> > > 
> > > cargo:warning=glsl-optimizer/src/compiler/glsl_types.cpp:376:14: error: use of undeclared identifier 'uint8_t_type'
> > > cargo:warning=      return uint8_t_type;
> > > cargo:warning=             ^
> > > cargo:warning=glsl-optimizer/src/compiler/glsl_types.cpp:380:14: error: use of undeclared identifier 'int16_t_type'; did you mean '__int16_t_type'?
> > > cargo:warning=      return int16_t_type;
> > > cargo:warning=             ^~~~~~~~~~~~
> > > cargo:warning=             __int16_t_type
> > > cargo:warning=glsl-optimizer/src/compiler/builtin_type_macros.h:50:1: note: '__int16_t_type' declared here
> > > cargo:warning=DECL_VEC_TYPE(int16_t,   i16vec, GLSL_TYPE_INT16,   GL_INT16, _NV)
> > > cargo:warning=^
> > > cargo:warning=glsl-optimizer/src/compiler/builtin_type_macros.h:35:4: note: expanded from macro 'DECL_VEC_TYPE'
> > > cargo:warning=   DECL_TYPE(stype,      etype ##__VA_ARGS__,         btype, 1, 1)   \
> > > cargo:warning=   ^
> > > cargo:warning=glsl-optimizer/src/compiler/glsl_types.h:344:34: note: expanded from macro 'DECL_TYPE'
> > > cargo:warning=   static const glsl_type *const NAME##_type;
> > > cargo:warning=                                 ^
> > > cargo:warning=<scratch space>:3:1: note: expanded from here
> > > cargo:warning=__int16_t_type
> > 
> > I have no idea what's going on here.
> 
> https://mail-index.netbsd.org/tech-userlevel/2018/09/08/msg011381.html
> Probably this. It's fixed in newer NetBSD.

Also graphics/MesaLib/patches/patch-src_compiler_builtin__type__macros.h
is the hack for it.