syncthing and old NetBSD, macOS

[Greg Troxel <gdt%lexort.com@localhost>]

If you use syncthing on old macOS (< 10.10?) or old NetBSD (<7), this
change might cause you trouble, as it will cause go 1.14 to be used
instead of the last-working version defaulted to on specific plaforms.

If you build syncthing from pkgsrc on those old systems, and it actually
worked in 2020Q2, please test and also try without the forcing of 114.

We don't expect that those old systems could build recent syncthing
anyway, so our working hypothesis is that there are no pkgsrc/syncthing
users on these systems.  Speak up if that's wrong.

Thanks to tnn@ and bsiegert@ for noticing the issue and figuring out
what to do.

Greg

--- Begin Message ---

• To: pkgsrc-changes%NetBSD.org@localhost
• Subject: CVS commit: pkgsrc/net/syncthing
• From: "Benny Siegert" <bsiegert%netbsd.org@localhost>
• Date: Sun, 6 Sep 2020 17:38:33 +0000

Module Name:	pkgsrc
Committed By:	bsiegert
Date:		Sun Sep  6 17:38:33 UTC 2020

Modified Files:
	pkgsrc/net/syncthing: Makefile

Log Message:
syncthing: hardcode Go 1.14 for now, bump revision

syncthing builds with Go 1.15 but panics on startup, which is why my bulk
build has not found this. This will be fixed in the next upstream version.

Discussed with tnn@ and gdt@


To generate a diff of this commit:
cvs rdiff -u -r1.116 -r1.117 pkgsrc/net/syncthing/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/net/syncthing/Makefile
diff -u pkgsrc/net/syncthing/Makefile:1.116 pkgsrc/net/syncthing/Makefile:1.117
--- pkgsrc/net/syncthing/Makefile:1.116	Thu Sep  3 07:29:36 2020
+++ pkgsrc/net/syncthing/Makefile	Sun Sep  6 17:38:33 2020
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.116 2020/09/03 07:29:36 bsiegert Exp $
+# $NetBSD: Makefile,v 1.117 2020/09/06 17:38:33 bsiegert Exp $
 
 # Upstream used to frequently break protocol compatibility, but since
 # 2018 or so this has been much better.  While users of pkgsrc
@@ -19,7 +19,7 @@
 # updates not following the above policy will be reverted.
 DISTNAME=	syncthing-source-v1.7.1
 PKGNAME=	${DISTNAME:S,source-v,,}
-PKGREVISION=	2
+PKGREVISION=	3
 CATEGORIES=	net
 MASTER_SITES=	${MASTER_SITE_GITHUB:=syncthing/}
 GITHUB_RELEASE=	v${PKGVERSION_NOREV}
@@ -95,6 +95,9 @@ do-install:
 		${DESTDIR}${PREFIX}/share/icons/hicolor/${s}x${s}/apps/syncthing.png
 .endfor
 
+# Remove after next update. As of 1.7.1, syncthing does not work with Go 1.15.
+GO_VERSION_DEFAULT=	114
+
 .include "../../lang/go/go-package.mk"
 .include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../sysutils/desktop-file-utils/desktopdb.mk"

--- End Message ---