Re: Patch: lang/python38: Fix for macOS 11 and Apple SIlicon

[nia <nia%NetBSD.org@localhost>]

On Tue, Nov 17, 2020 at 09:25:51PM +0100, Sijmen J. Mulder wrote:
> Sijmen Mulder <ik%sjmulder.nl@localhost> wrote:
> > > This patch is essentially the same as the python39 one, but backported
> > > to python38.
> > > 
> > > Patches consist of:
> > > - Upstream work: https://github.com/python/cpython/pull/22855
> > > - Fix for setup.py to find libbz2.tbd and libz.tbd now that with the
> > >   shared library cache there's nothing in /usr/lib.
> > >   See: https://bugs.python.org/issue41116
> > > - Addition of __arch64__ case to fix _decimal module. A very similar fix
> > >   has since been committed upstream.
> > > 
> > > Q: is this worth a revbump? The intention of the patch is only to
> > > fix the build, but the changes to the modules might warrant it.
> > > Goes for python39 too.
> > 
> > Attached a new version of the patch with the following changes:
> >  - Bump PKGREVISION
> >  - (Trailing) whitespace
> >  - Fix warning: unused variable
> >  - Drop OSX->macOS text changes, just noise
> >  - Fix: return -1 instead of NULL in posixmodule.c
> >  - Fix: wrong argument in posixmodule.c
> > 
> > Found these while working on 3.7 (that patch already incorporates
> > these fixes).
> > 
> > > OK to commit?
> 
> Committed, and the python37 version as well.

can you move __has_attribute inside the ifdef block? otherwise
it breaks with older compilers