Re: [patch] devel/ocamlgraph - fix Makefile typo

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Mon, 19 Jul 2021 at 11:49, Adam <adam%netbsd.org@localhost> wrote:
>
> > Hi,
> >
> > Just came across this typo in the devel/ocamlgraph Makefile:
> >
> > ===
> > .  if ${OCAML_USE_OPT_COMPILER} == "yes"
> >        ${INSTALL_PROGRAM} ${WRKSRC}/editor/editor.opt ${DESTDIR}${PREFIX}/bin/graph-editor
> >        ${INSTALL_PROGRAM} ${WRKSRC}/dgraph/dgraph.opt ${DESTDIR}${PREFIX}/bin/graph-viewer
> > .  else
> >        ${INSTALL_PROGRAM} ${WKRSRC}/editor/editor.byte ${DESTDIR}${PREFIX}/bin/graph-editor
> >                           ^^^^^^^^^
> >        ${INSTALL_PROGRAM} ${WKRSRC}/dgraph/dgraph.byte ${DESTDIR}${PREFIX}/bin/graph-viewer
> >                           ^^^^^^^^^
> > .  endif
> > ===
> >
> > Patch attached.
> >
> > Cheers, MJ
>
> Fixed.
>
> Thanks,
> Adam
Took me five minutes to figure out what the diff was...

Anyway, doesn't build with lablgtk option:

....
ocamlc.opt -c -I src -I lib -g -dtypes -w +a -w -4 -w -44 -w -50 -w
-48 -w -29 -I /usr/pkg/lib/ocaml/site-lib/lablgtk2 -I view_graph -I .
-I /usr/pkg/lib/ocaml/site-lib/lablgtk2 -I view_graph -I .
view_graph/viewGraph_core.mli
File "view_graph/viewGraph_core.mli", line 36, characters 34-48:
36 | type t_gtk_obj = GnomeCanvas.re_p GnoCanvas.item
                                       ^^^^^^^^^^^^^^
Error: Unbound module GnoCanvas

etc.
.....

Chavdar


-- 
----