Re: lang/nodejs builds, works fine with python 39

[Louis Guillaume <louis%zabrico.com@localhost>]

Thanks Jonathan,

Do you think something like this might be workable? It appears to DTRT 
on my systems, although it does require both versions of python if the 
PYTHON_VERSION_DEFAULT isn't "27" (and PKG_OPTIONS.node has "dtrace"). 
Keeps unwanted builds of python27 away!

Index: lang/nodejs/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/Makefile,v
retrieving revision 1.215
diff -u -r1.215 Makefile
--- lang/nodejs/Makefile        21 May 2021 06:56:28 -0000      1.215
+++ lang/nodejs/Makefile        4 Aug 2021 18:50:38 -0000
@@ -13,8 +13,6 @@
 CONFIGURE_ARGS+=       --shared-nghttp2
 CONFIGURE_ARGS+=       --with-intl=system-icu

-PYTHON_VERSIONS_ACCEPTED=      27
-
 CHECK_PORTABILITY_SKIP+= 
tools/macos-installer/pkgbuild/npm/scripts/preinstall

 .if ${MACHINE_ARCH} == "i386"
Index: lang/nodejs/options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/options.mk,v
retrieving revision 1.13
diff -u -r1.13 options.mk
--- lang/nodejs/options.mk      25 Jan 2020 10:45:12 -0000      1.13
+++ lang/nodejs/options.mk      4 Aug 2021 18:50:38 -0000
@@ -16,6 +16,7 @@
 PLIST_VARS+=           dtrace

 .if !empty(PKG_OPTIONS:Mdtrace)
+PYTHON_VERSIONS_ACCEPTED=      27
 CONFIGURE_ARGS+=       --with-dtrace
 PLIST.dtrace=          yes
 .else
cvs diff: Diffing lang/nodejs/patches



--
Louis

On 8/2/21 4:19 PM, Jonathan Perkin wrote:
> * On 2021-08-02 at 20:30 BST, Louis Guillaume wrote:
>
> > I noticed that lang/nodejs has PYTHON_VERSIONS_ACCEPTED= 27
> >
> > But nodejs builds and runs fine (according to my very minimal testing) 
> > with Python 39 on NetBSD-9.2 and on MacOS-11.5.1 (big sur).
> >
> > Is there a reason we're still locked in to python27 on this package?
>
> There is a script that is still python2-only in the distribution, IIRC 
> it's used when enabling the dtrace option.