Re: xentools415 build failure on NetBSD 9.99.90 amd64

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Oct 14, 2021 at 09:43:12AM +0100, Patrick Welche wrote:
> On Wed, Oct 13, 2021 at 08:11:47PM +0200, Manuel Bouyer wrote:
> > On Wed, Oct 13, 2021 at 10:44:10AM +0200, Manuel Bouyer wrote:
> > > On Tue, Oct 12, 2021 at 06:38:37PM +0200, Manuel Bouyer wrote:
> > > > On Tue, Oct 12, 2021 at 05:45:02PM +0200, Jan-Hinrich Fessel wrote:
> > > > > Not to my knowledge. Should I?
> > > > 
> > > > No. But AFAIK not much changed since I compiled it a few weeks ago.
> > > > I'll have to upgrade and test again
> > > 
> > > OK, it builds fine in 2021Q3, but fails in HEAD.
> > > Now the problem is to find what changed between the branch and HEAD which
> > > causes this. stacks.c is not generated on the fly, it's part of the
> > > sources.
> > 
> > OK, it's because the default for MKPIE changed.
> > Should be fixed with Makefile rev 1.4
> 
> Defaults for RELRO changed too... With a PKG_DEVELOPER=yes build,
> on install I see:
> 
> => Checking for RELRO in xentools415-4.15.1
> ERROR: bin/qemu-img-xen: missing RELRO
> ERROR: lib/debug/usr/pkg/libexec/xen/boot/xen-shim-syms: missing RELRO
> ERROR: libexec/xen/bin/qemu-dm: missing RELRO
> ERROR: libexec/xen/boot/xen-shim: missing RELRO

I don't know why bin/qemu-img-xen is missing RELRO, but for the others
this is expected: these are not NetBSD binaries.
Should I disable RELRO for the entire package, or is there a way to
exclude the check for some binaries ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--