Re: gcc10 with Ada support added to wip

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Fri, 5 Nov 2021 at 08:17, Fernando Oleo Blanco <irvise_ml%irvise.xyz@localhost> wrote:
>
> Hi everybody,
>
> On 05.11.21 01:11, nia wrote:
> > It looks good, thanks for working on this, and for listening to
> > my nitpicking on IRC.
>
> It is fine, I really want to get this done right so that it may be as
> useful and maintainable as possible. Thank you for the feedback.
>
> > If it successfully builds in a sandbox and the remaining pkglint
> > problems are fixed I think this is ready for commit.
> >
>
> It built in a clean install. I will ask Jay to try and build it in a
> sandbox. I will do so too and report back.
>
> Regarding the pkglint issues. I based gcc10-aux on gcc10. pkglint lists
> the following when run on lang/gcc10 (from current):
>
> WARN: Makefile:182: Invalid make target "||".
> WARN: Makefile:182: The user-defined variable MAKE_JOBS is used but not
> added to BUILD_DEFS.
> WARN: README.html: Invalid symlink name.
> WARN: options.mk:32: Variable names starting with an underscore
> (_GNU_INCLUDE_DIR) are reserved for internal pkgsrc use.
> WARN: options.mk:34: Variable names starting with an underscore
> (_GNU_INCLUDE_DIR) are reserved for internal pkgsrc use.
> WARN: options.mk:55: Variable names starting with an underscore
> (_libdir_) are reserved for internal pkgsrc use.
> WARN: options.mk:3: The buildlink3 identifier "gcc10" should be the same
> as the options identifier "${GCC_PKGNAME}".
> ERROR: patches/patch-gcc_ggc-common.c:3: Each patch must be documented.
> 1 error and 7 warnings found.
> (Run "pkglint -e" to show explanations.)
>
> For that reason, I will not fix these warning nor error, as they are not
> under my watch (they are not major ones in my opinion, appart from the
> patch documentation). However, obviously, if they are fixed in
> lang/gcc10, I will port those fixes to gcc10-aux.
>
> I have fixed the other warnings and issues that were not the same in
> wip/gcc10-aux. I have just pushed the fixes to wip.

I tried to build it under -current from yesterday and also current
enough pkgsrc. For me, lang/gcc6-aux fails early with:
....
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-optimize-isl.c:
In function 'isl_schedule_node*
get_schedule_for_node_st(isl_schedule_node*, void*)':
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-optimize-isl.c:59:52:
error: 'isl_space_dim' was not declared in this scope
   unsigned dims = isl_space_dim (space, isl_dim_set);
                                                    ^
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-optimize-isl.c:62:24:
error: 'isl_space_free' was not declared in this scope
   isl_space_free (space);
                        ^
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-dependences.c:
In function 'isl_map* constrain_domain(isl_map*, isl_set*)':
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-dependences.c:48:53:
error: 'isl_space_get_tuple_id' was not declared in this scope
   isl_id *id = isl_space_get_tuple_id (d, isl_dim_in);
                                                     ^
/usr/pkgsrc/lang/gcc6-aux/work/gcc-6.2.0/gcc/graphite-dependences.c:51:20:
error: 'isl_space_free' was not declared in this scope
   isl_space_free (d);
                    ^
..........(many more).


>
> Regards,
> --
> Fernando Oleo Blanco
> https://irvise.xyz
>

Chavdar


-- 
----