Re: Patch: fix pkg_install for OpenBSD 7.1's LIbreSSL

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Thu, 21 Apr 2022 22:09:44 +0200
Sijmen Mulder <ik%sjmulder.nl@localhost> wrote:

> Hi all,
> 
> OpenBSD 7.1 was just released and pkgsrc failed to bootstrap
> with a build error in pkg_install:
> 
> 
>   pkcs7.c:176:8: error: incomplete definition of type 'struct x509_st'
>                           if (X509_get_extended_key_usage(sk_X509_value(signers, i)) != pkg_key_usage) {
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   pkcs7.c:60:41: note: expanded from macro 'X509_get_extended_key_usage'
>   #define X509_get_extended_key_usage(x) x->ex_xkusage
>                                        ~^
> 
> This macro (and another) get defined conditionally as a fallback
> for older OpenSSL versions, and for LibreSSL. But now LibreSSL has
> introduced the functions too. Attached patch updates the check.
> 
> This is not usually my area, so ok to commit?

Unlikely to break anything for OpenSSL, so I think it is ok.
But out of curiosity, does your LibreSSL set OPENSSL_VERSION_NUMBER,
and if so to what value?