Re: xentools415

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Jul 01, 2022 at 04:13:44PM +0200, Manuel Bouyer wrote:
> On Fri, Jul 01, 2022 at 03:50:31PM +0200, Thomas Klausner wrote:
> > On Fri, Jul 01, 2022 at 02:52:09PM +0200, Manuel Bouyer wrote:
> > > On Fri, Jul 01, 2022 at 01:15:53PM +0100, Patrick Welche wrote:
> > > > Something happened to xentools415...
> > > > 
> > > > 
> > > > # pwd
> > > > /usr/pkgsrc/sysutils/xentools415
> > > > # cvs diff -urHEAD
> > > > # make show-var VARNAME=PKGNAME
> > > > make: "/usr/pkgsrc/lang/python/extension.mk" line 34: warning: duplicate script for target "do-build" ignored
> > > > make: "Makefile" line 166: warning: using previous script for "do-build" defined here
> > > > make: "/usr/pkgsrc/lang/python/extension.mk" line 38: warning: duplicate script for target "do-install" ignored
> > > > make: "Makefile" line 170: warning: using previous script for "do-install" defined here
> > > > xen-4.15.2nb3
> > > 
> > > Yes, I noticed this too. Something changed in the infrastructure which cause
> > > these warnings to be printed. xentools415 (and previous xentools4*) have
> > > been defining do-build and do-install ~forever.
> > 
> > This happened when you converted it from extension.mk to egg.mk.
> 
> it's not me who converted it. I know ~nothing about python.

Ah, sorry, that's right, you just did that change for xentools413,
which now has the same symptoms.

Including egg.mk adds do-build and do-install targets. It's not really
supporting packages that are not python-module-only packages but just
want to install python modules too very well.

> > I don't know which of the build commands should be done first or if
> > one is superfluous, and this package doesn't build for me - the one in
> 
> how does it fail ? It does build fine for me

On 9.99.98 with
PKGSRC_USE_SSP=         all
PKGSRC_USE_STACK_CHECK?=        yes
PKGSRC_USE_RELRO=       full
CFLAGS+=-g
CPPFLAGS+=-g
CXXPPFLAGS+=-g

I see:
ar rc libxenlight.a osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o libxl_nonetbuffer.o libxl_convert_callout.o libxl_remus.o libxl_checkpoint_device.o libxl_remus_disk_drbd.o libxl_no_colo.o dsdt_pvh.o build.o static_tables.o libxl_cpuid.o libxl_x86.o libxl_psr.o libxl_x86_acpi.o libxl_netbsd.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o libxl_dom.o libxl_exec.o libxl_xshelp.o libxl_device.o libxl_internal.o libxl_utils.o libxl_uuid.o libxl_json.o libxl_aoutils.o libxl_numa.o libxl_vnuma.o libxl_stream_read.o libxl_stream_write.o libxl_save_callout.o _libxl_save_msgs_callout.o libxl_qmp.o libxl_event.o libxl_fork.o libxl_dom_suspend.o libxl_dom_save.o libxl_usb.o libxl_vtpm.o libxl_nic.o libxl_disk.o libxl_console.o libxl_cpupool.o libxl_mem.o libxl_sched.o libxl_tmem.o libxl_9pfs.o libxl_domain.o libxl_vdispl.o libxl_pvcalls.o libxl_vsnd.o libxl_vkb.o libxl_genid.o _libxl_types.o libxl_flask.o _libxl_types_internal.o
testidl.c: In function 'main':
testidl.c:7067:1: error: frame size too large for reliable stack checking [-Werror]
 7067 | }
      | ^
cc1: all warnings being treated as errors


When I add
BUILDLINK_TRANSFORM+=	rm:-Werror
to the package Makefile to work around this, it fails with:

  Building ld scripts
python3.10 ./scripts/buildversion.py -e "-Xen" -t "gcc;as;ld;objcopy;objdump;strip" out/autoversion.h
Version: rel-1.14.0-20220701_142130-yt.nih.at-Xen
gcc -Iout/ -Isrc -Os -MD -g -Wall -Wno-strict-aliasing -Wold-style-definition -Wtype-limits -m32 -march=i386 -mregparm=3 -mpreferred-stack-boundary=2 -minline-all-stringops -fomit-frame-pointer -freg-struct-return -ffreestanding -fno-delete-null-pointer-checks -ffunction-sections -fdata-sections -fno-common -fno-merge-constants -fno-pie -fno-stack-protector -fstack-check=no -Wno-address-of-packed-member -fcf-protection=none -DMODE16=0 -DMODESEGMENT=0 -c src/version.c -o out/version.o
ld -melf_i386 -r out/ccode32flat.o out/version.o -o out/code32flat.o
ld -melf_i386 -r out/ccode16.o out/romlayout.o -o out/code16.o
objdump -thr out/code32flat.o > out/code32flat.o.objdump
objdump -thr out/code32seg.o > out/code32seg.o.objdump
objdump -thr out/code16.o > out/code16.o.objdump
python3.10 ./scripts/layoutrom.py out/code16.o.objdump out/code32seg.o.objdump out/code32flat.o.objdump out/autoconf.h out/romlayout16.lds out/romlayout32seg.lds out/romlayout32flat.lds
Fixed space: 0xe05b-0x10000  total: 8101  slack: 10  Percent slack: 0.1%
16bit size:           38496
32bit segmented size: 2176
32bit flat size:      46032
32bit flat init size: 84192
Lowmem size:          2240
f-segment var size:   1232
  Linking out/rom32seg.o
  Linking out/rom16.o
ld -T out/romlayout32seg.lds out/code32seg.o -o out/rom32seg.o
ld -T out/romlayout16.lds out/code16.o -o out/rom16.o
  Stripping out/rom32seg.noexec.o
strip out/rom32seg.o -o out/rom32seg.o.strip.o
python3.10 ./scripts/ldnoexec.py out/rom32seg.o.strip.o out/rom32seg.noexec.o
  Stripping out/rom16.noexec.o
strip out/rom16.o -o out/rom16.o.strip.o
python3.10 ./scripts/ldnoexec.py out/rom16.o.strip.o out/rom16.noexec.o
Traceback (most recent call last):
  File "/scratch/sysutils/xentools415/work/seabios-rel-1.14.0/./scripts/ldnoexec.py", line 32, in <module>
    main()
  File "/scratch/sysutils/xentools415/work/seabios-rel-1.14.0/./scripts/ldnoexec.py", line 20, in main
    f = open(infilename, "rb")
FileNotFoundError: [Errno 2] No such file or directory: 'out/rom32seg.o.strip.o'
gmake[6]: *** [Makefile:133: out/rom32seg.noexec.o] Error 1
gmake[6]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "/scratch/sysutils/xentools415/work/seabios-rel-1.14.0/./scripts/ldnoexec.py", line 32, in <module>
    main()
  File "/scratch/sysutils/xentools415/work/seabios-rel-1.14.0/./scripts/ldnoexec.py", line 20, in main
    f = open(infilename, "rb")
FileNotFoundError: [Errno 2] No such file or directory: 'out/rom16.o.strip.o'
gmake[6]: *** [Makefile:133: out/rom16.noexec.o] Error 1
gmake[6]: Leaving directory '/scratch/sysutils/xentools415/work/seabios-rel-1.14.0'
gmake[5]: *** [Makefile:138: subdir-all-seabios-dir] Error 2
gmake[5]: Leaving directory '/scratch/sysutils/xentools415/work/xen-4.15.2/tools/firmware'
gmake[4]: *** [/scratch/sysutils/xentools415/work/xen-4.15.2/tools/firmware/../../tools/Rules.mk:156: subdirs-all] Error 2
gmake[4]: Leaving directory '/scratch/sysutils/xentools415/work/xen-4.15.2/tools/firmware'
gmake[3]: *** [Makefile:37: all] Error 2
gmake[3]: Leaving directory '/scratch/sysutils/xentools415/work/xen-4.15.2/tools/firmware'
gmake[2]: *** [/scratch/sysutils/xentools415/work/xen-4.15.2/tools/../tools/Rules.mk:161: subdir-all-firmware] Error 2
gmake[2]: Leaving directory '/scratch/sysutils/xentools415/work/xen-4.15.2/tools'
gmake[1]: *** [/scratch/sysutils/xentools415/work/xen-4.15.2/tools/../tools/Rules.mk:156: subdirs-all] Error 2
gmake[1]: Leaving directory '/scratch/sysutils/xentools415/work/xen-4.15.2/tools'
gmake: *** [Makefile:63: build-tools] Error 2
*** Error code 2


 Thomas