Re: [PATCH 1/2] emacs28: move x11 dependencies to condition

[nia <nia%NetBSD.org@localhost>]

On Fri, Jul 08, 2022 at 08:08:48AM -0400, Greg Troxel wrote:
> 
> nia <nia%NetBSD.org@localhost> writes:
> 
> > On Mon, Jul 04, 2022 at 11:48:16AM +0200, J. Dekker wrote:
> >> ---
> >>  editors/emacs28/Makefile   | 4 ----
> >>  editors/emacs28/options.mk | 4 ++++
> >>  2 files changed, 4 insertions(+), 4 deletions(-)
> >> 
> >>  These dependencies are not necessary unless x11 is being built.
> >
> > Possibly true for harfbuzz and cairo, but currently the .desktop
> > files and hicolor icons are installed unconditionally.
> 
> I'm overdue for moving to more recent emacs, but with emacs26-nox11
> there are zero package dependencies.
> 
> It does seem like a mild bug to have desktop file and icons, but maybe
> the bug is that the desktop file could be configured to open a terminal
> and run emacs in it, instead.  But I would bet that 99.9% of people who
> choose emacsNN-nox11 would never think of starting an emacs that way.
> 
> Also, there's a systemd config file, which is perhaps ok on platforms
> where systemd is native and pkgsrc is integrating (do we do that?) but
> is a (harmless) buglet on NetBSD.
> 
> I don't follow, though, because pkg_info, when invoked on the
> emacs28-nox11 package I built from 2022Q2, shows no dependencies.

The author is on macOS so presumably wants the native Mac interface
only.

I'm generally not much in favor of complicated "notdarwin notx11
notwhatever" PLIST conditions.