Re: shells/oh-my-posh

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Tue, 21 Mar 2023 at 12:43, Benny Siegert <bsiegert%gmail.com@localhost> wrote:
>
> > Upstream using a sysutil_linux module unconditionally is a bug.  I would
> > just file one at the oh-my-posh repo.
>
> It's a goutil bug. The _linux suffix in a file name automatically
> makes the file only built on Linux. Since there is nothing really
> Linux-specific in the code, the right solution would be to rename the
> file to _unix.go and add a //build constraint that includes other
> Unix-like OSes.
>
> Looking at the file further, it seems that the whole approach of that
> package is misguided. It has "isLinux", "isMac", "isWindows" etc.
> calls. Is NetBSD Linux in this logic?

I noticed the same. I believe there was an earlier version of the
software in question not written in go, which might have worked under
NetBSD as well. It is a bit of software that has its uses, but in my
view in current state does not have a place in pkgsrc proper - after
all, on the supported Windows, MacOS and Linux platforms it builds or
installs directly. While it is perfectly reasonable to have pkgsrc
packages targeting specific architecture/platform combinations as part
of its infrastructure, in my view a leaf utility package like this
should not be accepted if it does not build under the main pkgsrc
target platform. But obviously the better outcome would be to make it
buildable, either via patches or after working with upstream.


>
> --
> Benny



-- 
----