Re: firefox-112

[Taylor R Campbell <campbell+netbsd-pkgsrc-users%mumble.net@localhost>]

> Date: Tue, 30 May 2023 10:02:09 +0100
> From: David Brownlee <abs%absd.org@localhost>
> 
> We now have a PR for this - PR#57445 (thanks martin@ :)
> 
> Purely as a temporary measture I've committed a workaround for native
> X11 NetBSD - https://mail-index.netbsd.org/pkgsrc-changes/2023/05/30/msg275715.html
> pending a fix

Try the attached patch to ld.elf_so, and see it firefox runs on it
without your workaround?  (Apply the patch, run `make dependall &&
make install' in src/libexec/ld.elf_so, and then install the resulting
$DESTDIR/libexec/ld.elf_so on the target machine.)

This patch is uncommittable as is, but it might get at the root cause
(from joerg).

diff --git a/libexec/ld.elf_so/arch/x86_64/mdreloc.c b/libexec/ld.elf_so/arch/x86_64/mdreloc.c
index a04c05ea0aa7..adbab16003a7 100644
--- a/libexec/ld.elf_so/arch/x86_64/mdreloc.c
+++ b/libexec/ld.elf_so/arch/x86_64/mdreloc.c
@@ -227,7 +227,7 @@ _rtld_relocate_nonplt_objects(Obj_Entry *obj)
 
 		case R_TYPE(TPOFF64):
 			if (!defobj->tls_done &&
-			    _rtld_tls_offset_allocate(obj))
+			    _rtld_tls_offset_allocate(__UNCONST(defobj)))
 				return -1;
 
 			*where64 = (Elf64_Addr)(def->st_value -