Re: print/hplip fails to build

[Greg Troxel <gdt%lexort.com@localhost>]

Greg Troxel <gdt%lexort.com@localhost> writes:

> ld: cannot find -lcupsimage
> gmake: *** [Makefile:5837: hpcups] Error 1
> *** Error code 2

Further details:

  libcups 2.4.2 (in 2023Q1) has libcupsimage

  hplip (HEAD) builds with libcups/cups-base/cups at 2.4.2 and can print

  hplip built in early June fails to work

so it looks like:

  cups withdrew a library between 2.4.2 or 2.4.6, or added a dep we
  don't force, or ?

I don't find cupsimage mentioned in upstream Changes, so will head down
the "no longer builds".  The PLIST change from 2023Q1 to now is
suspicious:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/print/libcups/Makefile,v
retrieving revision 1.21
retrieving revision 1.26
diff -u -p -r1.21 -r1.26
--- Makefile	3 Jan 2023 17:36:30 -0000	1.21
+++ Makefile	19 Jun 2023 19:28:36 -0000	1.26
@@ -1,9 +1,8 @@
@@ -20,7 +19,6 @@ CONFLICTS+=	LPRng-[0-9]* LPRng-core-[0-9
 WRKSRC=			${WRKDIR}/${DISTNAME:S/-source//}
 UNLIMIT_RESOURCES=	datasize memorysize
 USE_LANGUAGES=		c c++	# pdftops is a C++ application
-USE_LIBTOOL=		yes
 USE_PKGLOCALEDIR=	yes
 USE_TOOLS+=		aclocal autoconf automake gmake pkg-config
 GNU_CONFIGURE=		yes
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/print/libcups/PLIST,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -p -r1.2 -r1.3
--- PLIST	10 May 2022 20:47:38 -0000	1.2
+++ PLIST	16 Jun 2023 23:42:21 -0000	1.3
@@ -15,8 +15,8 @@ include/cups/raster.h
 include/cups/sidechannel.h
 include/cups/transcode.h
 include/cups/versioning.h
-lib/libcups.la
-lib/libcupsimage.la
+lib/libcups.so
+lib/libcups.so.2
 lib/pkgconfig/cups.pc
 share/locale/ca/cups_ca.po
 share/locale/cs/cups_cs.po


Reverting the removal of USE_LIBTOOL, it builds libcupsimage.  I'll
commit tomorrow unless someone explains why that's wrong.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/print/libcups/Makefile,v
retrieving revision 1.26
diff -u -p -r1.26 Makefile
--- Makefile	19 Jun 2023 19:28:36 -0000	1.26
+++ Makefile	23 Jun 2023 00:33:07 -0000
@@ -19,6 +19,7 @@ CONFLICTS+=	LPRng-[0-9]* LPRng-core-[0-9
 WRKSRC=			${WRKDIR}/${DISTNAME:S/-source//}
 UNLIMIT_RESOURCES=	datasize memorysize
 USE_LANGUAGES=		c c++	# pdftops is a C++ application
+USE_LIBTOOL=		yes
 USE_PKGLOCALEDIR=	yes
 USE_TOOLS+=		aclocal autoconf automake gmake pkg-config
 GNU_CONFIGURE=		yes
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/print/libcups/PLIST,v
retrieving revision 1.3
diff -u -p -r1.3 PLIST
--- PLIST	16 Jun 2023 23:42:21 -0000	1.3
+++ PLIST	23 Jun 2023 00:33:07 -0000
@@ -15,8 +15,8 @@ include/cups/raster.h
 include/cups/sidechannel.h
 include/cups/transcode.h
 include/cups/versioning.h
-lib/libcups.so
-lib/libcups.so.2
+lib/libcups.la
+lib/libcupsimage.la
 lib/pkgconfig/cups.pc
 share/locale/ca/cups_ca.po
 share/locale/cs/cups_cs.po