Potential build fallout on Darwin

[Jonathan Perkin <jperkin%mnx.io@localhost>]

Hi,

I've now removed the generic BUILDLINK_TRANSFORM removals on Darwin that 
were previously masking a lot of build issues.

This resolves issues where packages were built with hard-coded compiler 
and linker flags that are not supported on the target platform, but 
means that it's likely a fair number of packages will now fail to build 
where previously they built fine.

I'll be monitoring the bulk builds and looking for those failures, but 
if you happen to find them first then please either let me know or fix 
them yourself by adding the requisite BUILDLINK_TRANSFORM rm:arg to an 
individual package Makefile once you are sure it's the correct fix and 
does not result in that argument being hard-coded into any installed 
files.

Cheers,

-- 
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com

--- Begin Message ---

• To: pkgsrc-changes%NetBSD.org@localhost
• Subject: CVS commit: pkgsrc/mk/platform
• From: "Jonathan Perkin" <jperkin%netbsd.org@localhost>
• Date: Wed, 19 Jul 2023 08:11:35 +0000

Module Name:	pkgsrc
Committed By:	jperkin
Date:		Wed Jul 19 08:11:35 UTC 2023

Modified Files:
	pkgsrc/mk/platform: Darwin.mk

Log Message:
mk: Remove generic BUILDLINK_TRANSFORMs on Darwin.

While these were useful in helping many packages to build out of the box,
it ended up resulting in some packages installing broken configuration
files as their configure tests for supported flags were passing.

For example, ruby packages were shipping an rbconfig.rb with LDFLAGS
containing -Wl,--no-as-needed, resulting in any ruby software built
outside of pkgsrc that required a compiler always failing.

These will instead need to be added to packages on an individual basis
where appropriate.


To generate a diff of this commit:
cvs rdiff -u -r1.129 -r1.130 pkgsrc/mk/platform/Darwin.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/mk/platform/Darwin.mk
diff -u pkgsrc/mk/platform/Darwin.mk:1.129 pkgsrc/mk/platform/Darwin.mk:1.130
--- pkgsrc/mk/platform/Darwin.mk:1.129	Thu Jul  6 19:35:37 2023
+++ pkgsrc/mk/platform/Darwin.mk	Wed Jul 19 08:11:35 2023
@@ -1,4 +1,4 @@
-# $NetBSD: Darwin.mk,v 1.129 2023/07/06 19:35:37 bacon Exp $
+# $NetBSD: Darwin.mk,v 1.130 2023/07/19 08:11:35 jperkin Exp $
 #
 # Variable definitions for the Darwin operating system.
 
@@ -190,22 +190,6 @@ _OPSYS_PREFER.linux-pam?=	native
 _OPSYS_PREFER.mit-krb5?=	native
 _OPSYS_PREFER.openssl?=		pkgsrc	# builtin deprecated from 10.7 onwards
 
-# Remove common GNU ld arguments incompatible with the Darwin linker.
-BUILDLINK_TRANSFORM+=	rm:-Wl,-O1
-BUILDLINK_TRANSFORM+=	rm:-Wl,-O2
-BUILDLINK_TRANSFORM+=	rm:-Wl,-Bdynamic
-BUILDLINK_TRANSFORM+=	rm:-Wl,-Bsymbolic
-BUILDLINK_TRANSFORM+=	rm:-Wl,-export-dynamic
-BUILDLINK_TRANSFORM+=	rm:-Wl,-no_warn_inits 
-BUILDLINK_TRANSFORM+=	rm:-Wl,-warn-common
-BUILDLINK_TRANSFORM+=	rm:-Wl,--as-needed
-BUILDLINK_TRANSFORM+=	rm:-Wl,--no-as-needed
-BUILDLINK_TRANSFORM+=	rm:-Wl,--disable-new-dtags
-BUILDLINK_TRANSFORM+=	rm:-Wl,--enable-new-dtags
-BUILDLINK_TRANSFORM+=	rm:-Wl,--export-dynamic
-BUILDLINK_TRANSFORM+=	rm:-Wl,--gc-sections
-BUILDLINK_TRANSFORM+=	rm:-Wl,--no-undefined
-
 _OPSYS_SUPPORTS_CWRAPPERS=	yes
 _OPSYS_SUPPORTS_MKTOOLS=	yes
 

--- End Message ---