Re: pango fails to build on netbsd-9?

[David Brownlee <abs%absd.org@localhost>]

On Mon, 4 Sept 2023 at 13:02, Greg Troxel <gdt%lexort.com@localhost> wrote:
>
> David Brownlee <abs%absd.org@localhost> writes:
>
> > Update (and resolution) on this
> >
> > pango copies files/pango-view.sh into WRKSRC, assuming the copy in the
> > pkgsrc tree was executable.
>
> Are you finding that the file is not executable, because the VCS you
> rare using does not preserve that, or because you are using an odd
> filesystem, or ?   In CVS it is executable.

It was a copy of pkgsrc which had not preserved execute permissions

> > <https://matrix.to/#/!ARCRMtOOqxCUNGvKrm:netbsd.org/$FIXpv6wFXNcJ0STok7zOvgOG71corMWKXccKQcGtXhY?via=netbsd.org>
> > I'm in turn assuming it's reasonable to replace
> > ${CP} ${FILESDIR}/pango-view.sh ${WRKSRC}/output/utils
> > with
> > ${INSTALL_SCRIPT} ${FILESDIR}/pango-view.sh ${WRKSRC}/output/utils
> >
> > unless there is a better pattern for copying something which needs to be
> > run as a script? :)
>
> INSTALL_SCRIPT is for copying from WRKDIR to DESTDIR.   While it should
> work for that, it feels like a use beyond the scope.
>
> Why does this need to be executable?  Looking at sources, it seems it
> can't be invoked with sh because that is hard to express in meson.
>
> How about ${CHMOD} +x with a note that it's working  around a vcs or fs
> bug?

This is a relatively insidious edge case as I had a full set of
webmail and database packages all up and running before I hit this
error, so did not think it was anything other than a package specific
issue

I'm OK for pkgsrc to have a requirement that it "must be run on a copy
of pkgsrc which has preserved execute permissions", with a note in the
guide. (though I expect a new user hitting the issue would probably
end up walking away without finding that as the error is non obvious).

I'd definitely be happy with a requirement that pkgsrc did not assume
such, though there probably should be an approved method (maybe a
${COPY_SCRIPT} as an alias to ${INSTALL_SCRIPT}) to do what is needed.

Thanks

David