Re: multimedia/vlc PLIST error

["John D. Baker" <jdbaker%consolidated.net@localhost>]

On Sun, 22 Oct 2023, John D. Baker wrote:

> Building "multimedia/vlc" from pkgsrc-HEAD w/o option "dbus"
> (PKG_DEFAULT_OPTIONS+=-dbus) fails during packaging due to a duplicate
> PLIST entry for "libdbus_plugin.la".
> 
> The first is controlled by "${PLIST.dbus}", but the duplicate is not.

It has been brought to my attention that a similar issue exists with
"libxwd_plugin.la".  The first instance is controlled by "${PLIST.x11}"
while the duplicate a few lines later is not.  I hadn't noticed since
I build with the "x11" option globally enabled in PKG_DEFAULT_OPTIONS.

The following (revised) patch resolves both of these issues:

+Index: multimedia/vlc/PLIST
+===================================================================
+RCS file: /cvsroot/pkgsrc/multimedia/vlc/PLIST,v
+retrieving revision 1.74
+diff -u -p -r1.74 PLIST
+--- multimedia/vlc/PLIST	15 Oct 2023 19:32:03 -0000	1.74
++++ multimedia/vlc/PLIST	23 Oct 2023 01:24:16 -0000
+@@ -265,8 +265,6 @@ lib/vlc/plugins/codec/libvorbis_plugin.l
+ lib/vlc/plugins/codec/libwebvtt_plugin.la
+ ${PLIST.x11}lib/vlc/plugins/codec/libxwd_plugin.la
+ ${PLIST.dbus}lib/vlc/plugins/control/libdbus_plugin.la
+-lib/vlc/plugins/codec/libxwd_plugin.la
+-lib/vlc/plugins/control/libdbus_plugin.la
+ lib/vlc/plugins/control/libdummy_plugin.la
+ lib/vlc/plugins/control/libgestures_plugin.la
+ lib/vlc/plugins/control/libhotkeys_plugin.la


-- 
|/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
|\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
| X  No HTML/proprietary data in email.   BSD just sits there and works!
|/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645