Re: audio/csound6 and devel/sdl12-compat failing on Darwin (macOS 14.0)

[Jason Bacon <jtocino%gmx.com@localhost>]

On 10/25/23 05:57, Jason Bacon wrote:
> On 10/25/23 01:16, Manuel Kuklinski wrote:
> > Am Dienstag 24 Oktober 2023 um 9:00:46 -0700, schrieb Jason Bacon 2,8K:
> > > Maybe replace MACOSX_FRAMEWORK_BUNDLE_VERSION with something else that
> > > refers to a dylib?  Just a guess, as I'm not a cmake guru.
> > >
> > > Gotta love build scripts almost as complicated as the application 
> > > itself...
> >
> > Hi!
> >
> > Could it be, that pkgsrc's cmake automatically passes the -bundle flag?
> > Reference is this mailing list entry (also Darwin and cmake - nearly the
> > same problem; also see the follow-ups):
> >
> > http://mail-index.netbsd.org/pkgsrc-users/2021/07/05/msg034116.html
> >
> > I'm not giving up, but I'm irritated, since upstream hasn't this problem
> > with Cmake.app...
>
> I'm usually irritated when porting cmake-based packages.  It's great 
> when it works, but a PITA when it doesn't (which is more often than not 
> in my experience).
>
> I'm not seeing any obvious clues in the pkgsrc mk files:
>
> Darwin tarpon.local  bacon ~/Pkgsrc/pkgsrc 1003: (pkgsrc): fgrep -ri 
> bundle mk/
>
> mk//init/tests/smf/test_common.sh:<!DOCTYPE service_bundle SYSTEM 
> '/usr/share/lib/xml/dtd/service_bundle.dtd.1'>
> mk//init/tests/smf/test_common.sh:<service_bundle type='manifest' 
> name='export'>
> mk//init/tests/smf/test_common.sh:</service_bundle>
> mk//init/tests/smf/test_common.sh:<!DOCTYPE service_bundle SYSTEM 
> '/usr/share/lib/xml/dtd/service_bundle.dtd.1'>
> mk//init/tests/smf/test_common.sh:<service_bundle type='manifest' 
> name='export'>
> mk//init/tests/smf/test_common.sh:</service_bundle>
>
> But indeed, when manually running cmake on the same dist, it does not 
> generate -bundle flags:
>
> Darwin tarpon.local  bacon ~ 1012: (pkgsrc): tar zxf 
> Pkgsrc/pkgsrc/distfiles/csound-6.18.1.tar.gz
> Darwin tarpon.local  bacon ~ 1013: (pkgsrc): mkdir build
> Darwin tarpon.local  bacon ~ 1014: (pkgsrc): cd build
> Darwin tarpon.local  bacon ~/build 1015: (pkgsrc): cmake 
> ../csound-6.18.1/ >& log
> Darwin tarpon.local  bacon ~/build 1016: (pkgsrc):
>
> And the plugins are built as dylibs.  So *something* pkgsrc is doing is 
> causing cmake to generate -bundle flags.  No idea what at this point.
>
> Maybe diffing the CMakeCache, Makefile, and other cmake outputs between 
> pkgsrc and the manual configuration will provide some clues?

Another possibility to consider is that pkgsrc is right and upstream is 
wrong.  Perhaps it actually *should* generate .so files rather than 
.dylib for loadable modules?  It might be easier to patch the code to 
look for .so, rather than patch the build to generate .dylib.  I'm not 
saying this is the case, just that I would investigate it.