Re: firefox102 problems (one minor, one new?)

[David Brownlee <abs%absd.org@localhost>]

On Thu, 26 Oct 2023 at 18:47, David Brownlee <abs%absd.org@localhost> wrote:
>
> On Thu, 26 Oct 2023 at 14:02, Greg Troxel <gdt%lexort.com@localhost> wrote:
> >
> > I have netbsd-10 amd64 system that I keep up to date along the netbsd-10
> > branch and along pkgsrc HEAD.
> >
> > Recently, firefox102 failed to build.
> >
> > 1) I ran it with MAKE_JOBS=1 to get cleaner logging, and that resulted
> > in:
> >
> >   gmake[3]: Entering directory '/tank0/ztmp/work-xen/www/firefox102/work/build/toolkit/library/rust'
> >   toolkit/library/rust/force-cargo-library-build
> >   /usr/pkg/bin/cargo rustc  --release --frozen --manifest-path /tank0/ztmp/work-xen/www/firefox102/work/firefox-102.15.0/toolkit/library/rust/Cargo.toml -j1 -j1 --lib --target=x86_64-unknown-netbsd --features 'moz_places webrtc glean_with_gecko glean_disable_upload with_dbus' --  -Clto=thin
> >   error: the argument '--jobs <N>' cannot be used multiple times
> >
> > which I recognize from previous situations.   But that's easy to avoid.
> >
> > 2) I'm getting a rust error, which I suspect is due to rust.  I had
> > built firefox102-102.15.0 on September 19, and installed rust-bin-1.72.1
> > yesterday.
> >
> > gmake[3]: Entering directory '/tank0/ztmp/work-xen/www/firefox102/work/build/security/rlbox'
> > ../../dist/host/bin/wasm2c -o rlbox.wasm.c rlbox.wasm
> > 01bd146: error: unexpected opcode: 0xfc 0xa
> >
> >
> > Does firefox102 build for others?
>
> I think that is https://bugzilla.mozilla.org/show_bug.cgi?id=1773200#c4
>
> Looks like a workaround is
>
> https://phabricator.services.mozilla.com/rMOZILLACENTRALd190451aa436ed6704b3f73bb91ddd71f6c48953
>
> (testing a local build now :)

Unfortunately that patch to set BULK_MEMORY_SOURCES= does not appear
to help. I've also tried blindly copying ./third_party/wasm2c and/or
./config/external/wasm2c_sandbox_compiler from firefox115 into
firefox102 without luck.

I think if the build could be poked into adding -mno-bulk-memory to
clang at the right point it Should Just Work, but there are... layers
in the firefox build.

Alternatively it might be possible to patch firefox102 to use the
wasm2c from devel/wabt rather than its shipped version. I'm going to
try a quick hack to run the build until it fails and then try
replacing the built wasm2c with a symlink to /usr/pkg/bin/wasm2c to
see if that approach might be worth trying

David