Re: firefox on i386?

[Havard Eidnes <he%NetBSD.org@localhost>]

>> esp            0xa40f1bbc          0xa40f1bbc
>>
>> which is neither 8- nor 16-byte aligned, and movdqa insists on
>> aligned arguments.
>
> This is usually worked around with -mstackrealign. Firefox sets that in
> CXXFLAGS for i386 but not in CFLAGS. Adding CFLAGS might be worth a shot.
> Could well be in a 3rd party library somewhere else in pkgsrc though.

I'm happy to report that this appears to actually have solved the
issue.  The EGL error messages all seem to be non-fatal.  I'm now
up & running with a self-built firefox 120.0 after applying this
patch & updating to the result:

Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/mozilla-common.mk,v
retrieving revision 1.271
diff -u -r1.271 mozilla-common.mk
--- mozilla-common.mk   23 Nov 2023 05:03:38 -0000      1.271
+++ mozilla-common.mk   29 Dec 2023 12:05:55 -0000
@@ -70,6 +70,7 @@
 .if ${MACHINE_ARCH} == "i386"
 # This is required for SSE2 code under i386.
 CXXFLAGS+=     -mstackrealign
+CFLAGS+=       -mstackrealign
 .endif
 
 CHECK_PORTABILITY_SKIP+=       ${MOZILLA_DIR}security/nss/tests/*/*.sh

OK to commit, I suppose?

Regards,

- Håvard