Re: wip/dte 1.11.1 committer request

[Kevin Bloom <kevin.bloom%posteo.net@localhost>]

Jason Bacon <jtocino%gmx.com@localhost> wrote:

> # Make PLIST consistent across platforms
> 
> --- GNUmakefile.orig    2024-01-03 13:58:59.331475591 +0000
> +++ GNUmakefile
> @@ -41,10 +41,8 @@ check: check-tests check-opts
>   install: install-bin install-man install-bash-completion
>   uninstall: uninstall-bin uninstall-man uninstall-bash-completion
> 
> -ifneq "$(KERNEL)" "Darwin"
> - install: install-desktop-file install-appstream
> - uninstall: uninstall-desktop-file uninstall-appstream
> -endif
> +install: install-desktop-file install-appstream
> +uninstall: uninstall-desktop-file uninstall-appstream
> 
>   install-bin: all
>          $(Q) $(INSTALL) -d -m755 '$(DESTDIR)$(bindir)'

I've updated wip/dte to include a similar patch to this. J appeared
to have attempted to upload one but either forgot to upload the
actual patch file or was using it temporarily to make the above
reference. Either way, I've uploaded a new one and I believe it
is good to go in terms of functionality.

I have three remaining questions:
1.) In my version of the patch, I moved the extra `install:` and
    `uninstall:` blocks into the existing ones (see below). Would it
    be better for ease-of-understanding to have just done the above
    and left there being 2 definitions of `install:` and `uninstall:`
    respectively?

2.) Patch comments. In the above, it's written from a package
    maintainer's point of view. In my version, I simply just say
    exactly what is done in the patch. What is the preferred method
    for this?

3.) J had mentioned my COMMIT_MSG being rather long and there are
    some points in the update that are rather inconspicuous, i.e. the
    addition of "15 new command flags" or something. The original
    changelog had listed all 15 flags but I removed them in favor of
    a shorter but far less valuable statement. I'm assuming this type
    of information is more or less irrelevant in a pkgsrc commit msg.
    Is this correct? (if so I'll update COMMIT_MSG)

Regards,

Kev