Re: firefox on i386?

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

> Yes, this seems to have been fixed, but I'm getting a different failure
> now:
 :
> /r0/build/pkgsrc/www/firefox/work/build/dist/include/js/Utility.h:486:20: error: static assertion failed: over-aligned type is not supported by JS_DECLARE_NEW_METHODS
>   486 |         alignof(T) <= alignof(max_align_t),                                 \
>       |         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

The following patch works around (as kludge):

---
$NetBSD$

--- js/public/Utility.h.orig	2023-11-29 19:59:34.000000000 +0000
+++ js/public/Utility.h
@@ -482,9 +482,6 @@ static inline void js_free(void* p) {
 #define JS_DECLARE_NEW_METHODS(NEWNAME, ALLOCATOR, QUALIFIERS)              \
   template <class T, typename... Args>                                      \
   QUALIFIERS T* MOZ_HEAP_ALLOCATOR NEWNAME(Args&&... args) {                \
-    static_assert(                                                          \
-        alignof(T) <= alignof(max_align_t),                                 \
-        "over-aligned type is not supported by JS_DECLARE_NEW_METHODS");    \
     void* memory = ALLOCATOR(sizeof(T));                                    \
     return MOZ_LIKELY(memory) ? new (memory) T(std::forward<Args>(args)...) \
                               : nullptr;                                    \

---

Not sure what's the right fix though.

glibc has the following change for i386:
 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1c13144a6252b1edc40c4900c6ea683aea6fc691

---
Izumi Tsutsui