Re: net/transmission-gtk build fails

["T K Spindler (moof)" <dogcow%babymeat.com@localhost>]

> [ 96%] Building CXX object gtk/CMakeFiles/transmission-gtk.dir/Session.cc.o
> /tmp/pkgs/net/transmission-gtk/work.x86_64/transmission-4.0.5/gtk/OptionsDialog.cc:341:38: error: 'get_files2' was not declared in this scope; did you mean 'get_files'?
>   341 |         auto const files = IF_GTKMM4(get_files2, get_files)();
> 
> This build was successful just a couple days ago (with an earlier pkgsrc
> and earlier NetBSD).

Since everything is terrible, get_files2 is apparently functionality
introduced in gtkmm 4.10 - but even better, transmission supposedly
has a check for gtkmm >= 4.11.1 and does not seem to do anything
with it. See https://github.com/transmission/transmission/pull/6131
for more details.

The hacky-but-compiles way is to add a reverse of the patch from
https://github.com/transmission/transmission/commit/0faad140868b0e0ae42ca633931f358fc3c4bed1.diff
Note that I have *not* tested this, as I don't have a working X setup
anywhere convenient right now. The better-but-probably-beyond-me thing
would be to update x11/gtkmm4 to something much more recent (4.13 is out,
4.2 is what's in pkgsrc); I do not have the cycles to build/test/check
what all updating that would do to pkgsrc. Or, I could revert the
transmission package. If you're willing, I'd appreciate you testing
with the reverse patch to see if it's functional at all, or if it leaves
things even more broken than before.