fixing cross/arm-none-eabi-gcc on macOS Sonoma

[David Young <dyoung%pobox.com@localhost>]

On macOS Sonoma 14.4.1 using Apple clang version 15.0.0 (clang-1500.3.9.4)
and Xcode 15.3, I could not build arm-none-eabi-gcc until I made a
small change to
pkgsrc/cross/arm-none-eabi-gcc/work/gcc-8.3.0/gcc/system.h,
moving these lines,

> /* There are an extraordinary number of issues with <ctype.h>.
>    The last straw is that it varies with the locale.  Use libiberty's
>    replacement instead.  */
> #include "safe-ctype.h"

right before the multiple-inclusion #endif,

> #endif /* ! GCC_SYSTEM_H */

Before I made that change, clang threw an error:

> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__locale:811:8: error: expected ';' at end of declaration
> iscntrl(_CharT __c, const locale& __loc)
> 

Thanks to Taylor R Campbell for pointing out that iscntrl may have been
#defined somewhere---it was!

David

-- 
David Young
dyoung%pobox.com@localhost    Urbana, IL    (217) 721-9981