Re: math/py-tables: patch to use pkgsrc blosc

[matthewd%fastmail.us@localhost]

Thank you, looks like upstream confirmed the need for both versions!

On Mon, Jun 17, 2024, at 3:15 AM, Thomas Klausner wrote:
> On Sun, Jun 16, 2024 at 05:53:50AM -0600, matthewd%fastmail.us@localhost wrote:
>> 
>> 
>> On Sun, Jun 16, 2024, at 1:03 AM, Thomas Klausner wrote:
>> > On Sat, Jun 15, 2024 at 08:13:56PM -0600, matthewd%fastmail.us@localhost wrote:
>> >> The below patch updates math/py-tables to use the pkgsrc copy of the "blosc" library, instead of its internal copy.  Both the internal copy, and the pkgsrc package are synced at the same version, 1.21.5.  Another benefit is that the internal copy also includes copies of lz4, zlib, and zstd that no longer need to be built.  Running "make test" on each package produces similar output.  
>> >
>> > Why does this need both blosc and blosc2? From blosc2's DESCR it should 
>> > be backwards compatible.
>> 
>> I thought as you did and was confused by why it was building v1 of the sources. However, the compatibility is more nuanced, and regardless of if we explicitly link in v1 support, it still wants to depend on v1 (https://www.pytables.org/usersguide/installation.html)
>> 
>> Also, from https://github.com/Blosc/c-blosc2
>> 
>> C-Blosc2 is the new major version of C-Blosc, and is backward compatible with both the C-Blosc1 API and its in-memory format. However, the reverse thing is generally not true for the format; buffers generated with C-Blosc2 are not format-compatible with C-Blosc1 (i.e. forward compatibility is not supported). In case you want to ensure full API compatibility with C-Blosc1 API, define the BLOSC1_COMPAT symbol.
>
> I've changed pkgsrc as you suggested and asked upstream about this.
>
> https://github.com/PyTables/PyTables/issues/1170
>  Thomas

-- 
  
  matthewd%fastmail.us@localhost