pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkglint fails to build



On Mon, Oct 07, 2024 at 01:42:26PM -0700, Paul Goyette wrote:
> On a amd64 host, starting with an empty sandbox, I am getting the
> following repeatable failure:
> 
> ...
> ===> Configuring for pkglint-23.8.0
> => Substituting "pkglint" in pkglint.go
> ===> Building for pkglint-23.8.0
> go telemetry: unknown command
> Run 'go help' for usage.
> *** Error code 2
> 
> Stop.
> make[1]: stopped making "install" in /build/pkgsrc/pkgtools/pkglint
> *** Error code 1
> 
> 
> /build/pkgsrc/ was updated on 2024-10-06 at 15:56:31 UTC

First rule of pkgsrc - update and try again ;)

It was fixed a bit later on the same day.
 Thomas
--- Begin Message ---
Module Name:	pkgsrc
Committed By:	bsiegert
Date:		Sun Oct  6 16:29:40 UTC 2024

Modified Files:
	pkgsrc/lang/go: go-module.mk

Log Message:
go-module.mk: unbreak with Go 1.22

A recent commit mistakenly added a call to "go telemetry off", which has
only been added in 1.23. This chunk was meant to be committed as part of
setting the default Go version to 1.22.

Sorry for the breakage, everyone!

PR pkg/58722 and various pings


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 pkgsrc/lang/go/go-module.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/lang/go/go-module.mk
diff -u pkgsrc/lang/go/go-module.mk:1.18 pkgsrc/lang/go/go-module.mk:1.19
--- pkgsrc/lang/go/go-module.mk:1.18	Thu Oct  3 15:41:00 2024
+++ pkgsrc/lang/go/go-module.mk	Sun Oct  6 16:29:39 2024
@@ -1,4 +1,4 @@
-# $NetBSD: go-module.mk,v 1.18 2024/10/03 15:41:00 bsiegert Exp $
+# $NetBSD: go-module.mk,v 1.19 2024/10/06 16:29:39 bsiegert Exp $
 #
 # This file implements common logic for compiling Go programs in pkgsrc.
 #
@@ -53,7 +53,6 @@ MAKE_ENV+=	GOTOOLCHAIN=local
 
 .if !target(do-build)
 do-build:
-	${RUN} cd ${WRKSRC} && ${_ULIMIT_CMD} ${PKGSRC_SETENV} ${MAKE_ENV} ${GO} telemetry off
 	${RUN} cd ${WRKSRC} && ${_ULIMIT_CMD} ${PKGSRC_SETENV} ${MAKE_ENV} ${GO} install -v ${GO_BUILD_PATTERN}
 .endif
 


--- End Message ---


Home | Main Index | Thread Index | Old Index