On Tue, Jan 15, 2008 at 03:00:17PM -0500, Michael Lorenz wrote: > Ok, we can easily work around that one. Are you sure it's a single > 0x20 and not some other whitespace? Yes, I tried the attached patch and it did the Right Thing. > > I wonder how Solaris deals with this. Do they just reset the card to > > a known state, or do they trim whitespace on nodes? > > I guess they have a native driver that doesn't use the depth > property. Or use the firmware for console output. Oh well. It doesn't matter much anyway, I think guessing a second time after "depth" is not found works well. Thanks again for helping me solve this problem! Cheers, Peter -- http://sjamaan.ath.cx -- "The process of preparing programs for a digital computer is especially attractive, not only because it can be economically and scientifically rewarding, but also because it can be an aesthetic experience much like composing poetry or music." -- Donald Knuth
? sys/arch/sparc64/compile/obj ? sys/arch/sparc64/conf/CANCERMAN Index: sys/arch/sparc64/sparc64/autoconf.c =================================================================== RCS file: /cvsroot/src/sys/arch/sparc64/sparc64/autoconf.c,v retrieving revision 1.148 diff -u -r1.148 autoconf.c --- sys/arch/sparc64/sparc64/autoconf.c 3 Jan 2008 21:34:58 -0000 1.148 +++ sys/arch/sparc64/sparc64/autoconf.c 15 Jan 2008 20:16:15 -0000 @@ -967,7 +967,9 @@ prop_dictionary_set_uint32(dict, "height", temp); } of_to_uint32_prop(dict, console_node, "linebytes", "linebytes"); - if (!of_to_uint32_prop(dict, console_node, "depth", "depth")) { + if (!of_to_uint32_prop(dict, console_node, "depth", "depth") && + /* Some cards have an extra space in the property name */ + !of_to_uint32_prop(dict, console_node, "depth ", "depth")) { /* * XXX we should check linebytes vs. width but those * FBs that don't have a depth property ( /chaos/control... )
Attachment:
pgpny62DhjHBS.pgp
Description: PGP signature