Re: Minor precedence issues in pmap_remap_pages()?

[Jed Davis <jdev%panix.com@localhost>]

I noticed a few more of those:

diff -u -r1.8.2.3 pmap.c
--- sys/arch/xen/i386/pmap.c    6 Jun 2005 12:16:10 -0000       1.8.2.3
+++ sys/arch/xen/i386/pmap.c    21 Jul 2005 03:55:43 -0000
@@ -3715,7 +3715,7 @@
                 * wired count might change...
                 */
                pmap->pm_stats.wired_count +=
-                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
+                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
 
                npte |= (opte & PG_PVLIST);
 
@@ -3801,7 +3801,7 @@
                 * wired count might change...
                 */
                pmap->pm_stats.wired_count +=
-                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
+                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
 
                if (opte & PG_PVLIST) {
                        pg = PHYS_TO_VM_PAGE(opte & PG_FRAME);
@@ -3985,7 +3985,7 @@
                 * wired count might change...
                 */
                pmap->pm_stats.wired_count +=
-                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
+                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
 
                XENPRINTK(("pmap update opte == pa"));
                /* zap! */
@@ -4036,7 +4036,7 @@
                 * wired count might change...
                 */
                pmap->pm_stats.wired_count +=
-                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
+                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
 
                if (opte & PG_PVLIST) {
                        opte = xpmap_mtop(opte);
@@ -4223,7 +4223,7 @@
                 * change since we are replacing/changing a valid mapping.
                 * wired count might change...
                 */
-               pmap->pm_stats.wired_count += (1 - (opte & PG_W) ? 1 : 0);
+               pmap->pm_stats.wired_count += 1 - ((opte & PG_W) ? 1 : 0);
 
                //printf("pmap_remap_pages opte == pa");
                /* zap! */
@@ -4262,7 +4262,7 @@
                 * change since we are replacing/changing a valid mapping.
                 * wired count might change...
                 */
-               pmap->pm_stats.wired_count += (1 - (opte & PG_W) ? 1 : 0);
+               pmap->pm_stats.wired_count += 1 - ((opte & PG_W) ? 1 : 0);
 
                if (opte & PG_PVLIST) {
                        opte = xpmap_mtop(opte);
__END__


-- 
(let ((C call-with-current-continuation)) (apply (lambda (x y) (x y)) (map
((lambda (r) ((C C) (lambda (s) (r (lambda l (apply (s s) l))))))  (lambda
(f) (lambda (l) (if (null? l) C (lambda (k) (display (car l)) ((f (cdr l))
(C k)))))))    '((#\J #\d #\D #\v #\s) (#\e #\space #\a #\i #\newline)))))