Port-xen archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: Xen/Xentools 3.3 Domain-Unnamed
On Tuesday 19 August 2008 14:18:51 Manuel Bouyer wrote:
> On Tue, Aug 19, 2008 at 02:00:22PM +0200, Christoph Egger wrote:
> > On Tuesday 19 August 2008 13:47:46 Manuel Bouyer wrote:
> > > On Tue, Aug 19, 2008 at 01:41:17PM +0200, Christoph Egger wrote:
> > > > This is what I got from XenSource:
> > > >
> > > > ---------------------------------------------------------------------
> > > >---- ------------- You'll need to do errno remapping at the bottom of
> > > > libxenctrl/libxenguest, or within your equivalent of Linux's privcmd
> > > > kernel driver.
> > > >
> > > > Either is easy -- even in libxc there's one shared macro or function
> > > > that provides access to the actual hypercall interface, I'm pretty
> > > > sure.
> > > > ---------------------------------------------------------------------
> > > >---- -------------
> > >
> > > I think the right way to do this would be to use the Xen's E* macros
> > > in the userland code where it's appropriate, and change the interface
> > > to return the hypervisor's errors though a different channel
> > > (as they don't have the same semantic as the errors from the local OS).
> > > But whatever
> >
> > That is a lot of work. First, you have to prefix Xen's E* macros and
> > change all C code to use them in order to not interfer with
> > <sys/errno.h>.
>
> Yes
>
> > Second, you have to maintain a copy as a python module since
> > python's errno is used.
>
> I don't think so. The point is to change the API, as python's errno
> errno is from the OS, not from the hypervisor. The hypervisor's
> errno would be passed as a parameter of the hypercall, just like other
> parameters.
>
> > Third, this is almost the opposite what XenSource said and therefore
> > I don't believe in accepting those patches (and I'm not going to maintain
> > patches in pkgsrc I don't get upstream).
> >
> > So this is not the way to go. Sorry.
>
> This is how I understood it.
>
> > > > I first tried to fix this in the xentools as suggested by XenSource.
> > > > But then I noticed this had an impact to *all* Dom0 privcmd ioctl's,
> > > > which made things worse.
> > > >
> > > > Reason: Only IOCTL_PRIVCMD_HYPERCALL is a passthrough from
> > > > userspace into the hypervisor and back. All others also perform
> > > > hypercalls into the hypervisor, but the return code from them
> > > > is never passed back into userspace.
> > > >
> > > > Therefore, the easiest fix (and with minimal effort) is to do
> > > > the error code remapping in sys/arch/xen/xen/privcmd.c after the
> > > > hypercall returned in IOCTL_PRIVCMD_HYPERCALL.
> > > >
> > > > Attached patch is doing this and works fine.
> > > > With it, there are no longer any phantom domains named
> > > > "Domain-Unnamed" left.
> > >
> > > Are EDEADLK/EAGAIN the only error codes that need translation ?
> >
> > I can think of EWOULDBLOCK but this is an alias to EAGAIN. So yes,
> > nothing else has bitten us so far.
>
> Not yet. I'd rather take the whole macro list and see what the differences
> are.
Attached is xen's errno file from the source.
In the source, this is: xen/include/xen/errno.h
It is basically a merge of Linux' asm-generic/errno-generic.h and
asm-generic/errno.h
Christoph
#ifndef _I386_ERRNO_H
#define _I386_ERRNO_H
#define EPERM 1 /* Operation not permitted */
#define ENOENT 2 /* No such file or directory */
#define ESRCH 3 /* No such process */
#define EINTR 4 /* Interrupted system call */
#define EIO 5 /* I/O error */
#define ENXIO 6 /* No such device or address */
#define E2BIG 7 /* Arg list too long */
#define ENOEXEC 8 /* Exec format error */
#define EBADF 9 /* Bad file number */
#define ECHILD 10 /* No child processes */
#define EAGAIN 11 /* Try again */
#define ENOMEM 12 /* Out of memory */
#define EACCES 13 /* Permission denied */
#define EFAULT 14 /* Bad address */
#define ENOTBLK 15 /* Block device required */
#define EBUSY 16 /* Device or resource busy */
#define EEXIST 17 /* File exists */
#define EXDEV 18 /* Cross-device link */
#define ENODEV 19 /* No such device */
#define ENOTDIR 20 /* Not a directory */
#define EISDIR 21 /* Is a directory */
#define EINVAL 22 /* Invalid argument */
#define ENFILE 23 /* File table overflow */
#define EMFILE 24 /* Too many open files */
#define ENOTTY 25 /* Not a typewriter */
#define ETXTBSY 26 /* Text file busy */
#define EFBIG 27 /* File too large */
#define ENOSPC 28 /* No space left on device */
#define ESPIPE 29 /* Illegal seek */
#define EROFS 30 /* Read-only file system */
#define EMLINK 31 /* Too many links */
#define EPIPE 32 /* Broken pipe */
#define EDOM 33 /* Math argument out of domain of func */
#define ERANGE 34 /* Math result not representable */
#define EDEADLK 35 /* Resource deadlock would occur */
#define ENAMETOOLONG 36 /* File name too long */
#define ENOLCK 37 /* No record locks available */
#define ENOSYS 38 /* Function not implemented */
#define ENOTEMPTY 39 /* Directory not empty */
#define ELOOP 40 /* Too many symbolic links encountered */
#define EWOULDBLOCK EAGAIN /* Operation would block */
#define ENOMSG 42 /* No message of desired type */
#define EIDRM 43 /* Identifier removed */
#define ECHRNG 44 /* Channel number out of range */
#define EL2NSYNC 45 /* Level 2 not synchronized */
#define EL3HLT 46 /* Level 3 halted */
#define EL3RST 47 /* Level 3 reset */
#define ELNRNG 48 /* Link number out of range */
#define EUNATCH 49 /* Protocol driver not attached */
#define ENOCSI 50 /* No CSI structure available */
#define EL2HLT 51 /* Level 2 halted */
#define EBADE 52 /* Invalid exchange */
#define EBADR 53 /* Invalid request descriptor */
#define EXFULL 54 /* Exchange full */
#define ENOANO 55 /* No anode */
#define EBADRQC 56 /* Invalid request code */
#define EBADSLT 57 /* Invalid slot */
#define EDEADLOCK EDEADLK
#define EBFONT 59 /* Bad font file format */
#define ENOSTR 60 /* Device not a stream */
#define ENODATA 61 /* No data available */
#define ETIME 62 /* Timer expired */
#define ENOSR 63 /* Out of streams resources */
#define ENONET 64 /* Machine is not on the network */
#define ENOPKG 65 /* Package not installed */
#define EREMOTE 66 /* Object is remote */
#define ENOLINK 67 /* Link has been severed */
#define EADV 68 /* Advertise error */
#define ESRMNT 69 /* Srmount error */
#define ECOMM 70 /* Communication error on send */
#define EPROTO 71 /* Protocol error */
#define EMULTIHOP 72 /* Multihop attempted */
#define EDOTDOT 73 /* RFS specific error */
#define EBADMSG 74 /* Not a data message */
#define EOVERFLOW 75 /* Value too large for defined data type */
#define ENOTUNIQ 76 /* Name not unique on network */
#define EBADFD 77 /* File descriptor in bad state */
#define EREMCHG 78 /* Remote address changed */
#define ELIBACC 79 /* Can not access a needed shared library */
#define ELIBBAD 80 /* Accessing a corrupted shared library */
#define ELIBSCN 81 /* .lib section in a.out corrupted */
#define ELIBMAX 82 /* Attempting to link in too many shared
libraries */
#define ELIBEXEC 83 /* Cannot exec a shared library directly */
#define EILSEQ 84 /* Illegal byte sequence */
#define ERESTART 85 /* Interrupted system call should be restarted
*/
#define ESTRPIPE 86 /* Streams pipe error */
#define EUSERS 87 /* Too many users */
#define ENOTSOCK 88 /* Socket operation on non-socket */
#define EDESTADDRREQ 89 /* Destination address required */
#define EMSGSIZE 90 /* Message too long */
#define EPROTOTYPE 91 /* Protocol wrong type for socket */
#define ENOPROTOOPT 92 /* Protocol not available */
#define EPROTONOSUPPORT 93 /* Protocol not supported */
#define ESOCKTNOSUPPORT 94 /* Socket type not supported */
#define EOPNOTSUPP 95 /* Operation not supported on transport
endpoint */
#define EPFNOSUPPORT 96 /* Protocol family not supported */
#define EAFNOSUPPORT 97 /* Address family not supported by protocol */
#define EADDRINUSE 98 /* Address already in use */
#define EADDRNOTAVAIL 99 /* Cannot assign requested address */
#define ENETDOWN 100 /* Network is down */
#define ENETUNREACH 101 /* Network is unreachable */
#define ENETRESET 102 /* Network dropped connection because of reset
*/
#define ECONNABORTED 103 /* Software caused connection abort */
#define ECONNRESET 104 /* Connection reset by peer */
#define ENOBUFS 105 /* No buffer space available */
#define EISCONN 106 /* Transport endpoint is already connected */
#define ENOTCONN 107 /* Transport endpoint is not connected */
#define ESHUTDOWN 108 /* Cannot send after transport endpoint
shutdown */
#define ETOOMANYREFS 109 /* Too many references: cannot splice */
#define ETIMEDOUT 110 /* Connection timed out */
#define ECONNREFUSED 111 /* Connection refused */
#define EHOSTDOWN 112 /* Host is down */
#define EHOSTUNREACH 113 /* No route to host */
#define EALREADY 114 /* Operation already in progress */
#define EINPROGRESS 115 /* Operation now in progress */
#define ESTALE 116 /* Stale NFS file handle */
#define EUCLEAN 117 /* Structure needs cleaning */
#define ENOTNAM 118 /* Not a XENIX named type file */
#define ENAVAIL 119 /* No XENIX semaphores available */
#define EISNAM 120 /* Is a named type file */
#define EREMOTEIO 121 /* Remote I/O error */
#define EDQUOT 122 /* Quota exceeded */
#define ENOMEDIUM 123 /* No medium found */
#define EMEDIUMTYPE 124 /* Wrong medium type */
#endif
Home |
Main Index |
Thread Index |
Old Index