Re: xbd detachment

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

Hi,
sorry for the delay

On Tue, Jul 28, 2009 at 06:23:41PM -0500, David Young wrote:
> Thanks, that patch was enormously helpful.
> 
> I got it to mostly work with one minor change, except that
> config_detach(,DETACH_FORCE) panicked: config_detach() really does not
> like for a driver's detachment routine to return != 0 if the detachment
> was forced.  So I made it so xbd_xenbus_detach(,DETACH_FORCE) waits for
> the detach to complete, while xbd_xenbus_detach(,!DETACH_FORCE) exits
> with EALREADY.  That seems to work fine.

what will happen if we call xbd_xenbus_detach(,DETACH_FORCE) from
a locally-initiated detach ? It looks like in this case both the
thread that initiaed the detach, and the xenbus thread will try to detach
the xbd; something wrong will probably result from this.

Anyway, you patch seems to work fine for the !DETACH_FORCE case and
I checked that a detach initated from domain0 also works fine.

> Included in my patch are some changes to the other xbd driver, whose
> sources are in xen/xbd.c.  Is that driver only applicable to Xen 2?  I
> still need to test that patch....

Yes, it was only for Xen 2.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--