Re: sysutils/xenkernel33

[Matt Fleming <matt%console-pimps.org@localhost>]

On Fri, Jul 02, 2010 at 10:53:27AM +0200, Christoph Egger wrote:
> 
> > > >> /* Intel P4 currently has largest cache line (L2 line size is 128
> > > bytes). */
> > > >> #define CONFIG_X86_L1_CACHE_SHIFT 7
> > > >
> > > > I see the same build error with xen-unstable, too.
> > > > Why is gcc suddenly that picky ?
> > 
> > What has been changed in gcc recently?
> > 
> > > > 
> > > is there a easy fix to get xentools33 to build?
> > 
> > You mean xenkernel33, right?
> > 
> > Other than downgrading userland? No idea.
> 
> Ok, the root cause has been found in discussion is mrg@:
> 
> http://mail-index.netbsd.org/source-changes/2010/06/01/msg010582.html
> 
> The __cacheline_aligned is visible to userland and
> xen includes <sys/cdefs_elf.h> through <stdarg.h>.
> 
> The xen kernel doesn't see COHERENCY_UNIT and is therefore
> complaining for the missing value.

Urgh, sorry about that.

> The question is why is __cacheline_aligned visible
> to userland?

It should not be.

> A quick fix is to edit /usr/include/sys/cdefs_elf.h
> and surround __cacheline_aligned with
> 
> #ifdef _KERNEL
> 
> ...
> 
> #endif

Yep, this fix should be done in HEAD.