Re: Balloon driver.

["Cherry G. Mathew" <cherry.g.mathew%gmail.com@localhost>]

Hi Christoph,

On 7 July 2010 14:30, Christoph Egger <Christoph_Egger%gmx.de@localhost> wrote:

[...]

>> > Though I have to report a bug:
>> >
>> > I have an amd64 Dom0 kernel w/o XEN_BALLOONING in the kernel config.
>> > Boot the xen kernel with dom0_mem=512m
>> >
>> > After login I do:
>> >
>> > # sysctl kern.xen
>> > kern.xen.balloon.current = 131072
>> > node_val out of range.
>> > node_val = 0
>> >
>> > I expect kern.xen.balloon.current to say 512MB and I don't expect to see
>> > the node_val messages.
>>
>> Whoops!
>>
>> Does the following patch fix it for you:
>
> I think, the ballooning sysctl's should be always there regardless if compiled
> with or w/o XEN_BALLOONING in the kernel config to prevent misbehaviour
> of the xen tools.
>
> If XEN_BALLOONING is not specified then the sysctl values should be
> a) read-only
> b) print reasonable fixed values.

http://mail-index.netbsd.org/source-changes/2010/07/08/msg011550.html

I hope this works for you.


Would the following patch work be ok for xentools ?

Cheers,
-- 
~Cherry

Index: sys/arch/xen/conf/files.xen
===================================================================
RCS file: /cvsroot/src/sys/arch/xen/conf/files.xen,v
retrieving revision 1.108
diff -u -r1.108 files.xen
--- sys/arch/xen/conf/files.xen 6 Jul 2010 15:00:09 -0000       1.108
+++ sys/arch/xen/conf/files.xen 8 Jul 2010 15:34:17 -0000
@@ -406,7 +406,7 @@
 file   arch/xen/xen/xennetback_xenbus.c xvif
 file   arch/xen/xen/xennet_checksum.c  xvif | xennet
 file   arch/xen/xen/xbdback_xenbus.c xbdback
-file    arch/xen/xen/balloon.c          hypervisor
+file    arch/xen/xen/balloon.c          hypervisor & xenbus & (
dom0ops | xen_balloon )

 ifdef i386
 include "arch/i386/conf/majors.i386"