Re: SMP related diffs.

[Hugo Silva <hugo%barafranca.com@localhost>]

On 03/24/11 05:57, Cherry G. Mathew wrote:
> Hello,
> 
> Here's a couple of diffs for review.
> 
> ftp://ftp.netbsd.org/pub/NetBSD/misc/cherry/tmp/port-xen/breakout/clock.c.diff
> 
> ftp://ftp.netbsd.org/pub/NetBSD/misc/cherry/tmp/port-xen/breakout/evtchn.c.diff
> 
> If you could please try them out on your existing UP domU/dom0 kernels
> and send me feedback, that would be great. The changes are very
> straightforward:
> 
> clock.c: Adds per cpu timer callback and hardclock()
> 
> evtchn.c: Adds locking primitives towards SMP.
> 
> I hope to merge these after more thorough testing.
> 
> Many Thanks,
> 

No luck here !

--- evtchn.o ---
#   compile  XEN3_DOMU/evtchn.o
/usr/src/obj/tooldir.NetBSD-5.99.48-amd64/bin/x86_64--netbsd-gcc
-mcmodel=kernel -mno-red-zone -ffreestanding
-fno-zero-initialized-in-bss -g -O2 -fno-omit-frame-pointer
-fstack-protector -Wstack-protector --param ssp-buffer-size=1
-fno-strict-aliasing -fstack-protector -Wstack-protector --param
ssp-buffer-size=1 -Werror -Wall -Wno-main -Wno-format-zero-length
-Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes -Wswitch
-Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code
-Wno-sign-compare -Wno-pointer-sign -Wno-attributes -Wextra
-Wno-unused-parameter -Werror -Damd64 -Dx86_64 -I.
-I/usr/obj/sys/arch/amd64/compile/XEN3_DOMU/xen-ma
-I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys
-nostdinc -DMAXPHYS=32768 -DDIAGNOSTIC -DDEBUG -DMAXUSERS=32 -D_KERNEL
-D_KERNEL_OPT -std=gnu99
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/x86_64/string
-I/usr/src/sys/dist/ipf -c /usr/src/sys/arch/xen/xen/evtchn.c
/usr/src/sys/arch/xen/xen/evtchn.c: In function 'evtchn_do_event':
/usr/src/sys/arch/xen/xen/evtchn.c:249: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:261: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:270: error: 'struct evtsource' has no
member named 'ev_lock'
cc1: warnings being treated as errors
/usr/src/sys/arch/xen/xen/evtchn.c: At top level:
/usr/src/sys/arch/xen/xen/evtchn.c:317: warning: no previous prototype
for 'bind_vcpu_to_evtch'
/usr/src/sys/arch/xen/xen/evtchn.c: In function 'event_set_handler':
/usr/src/sys/arch/xen/xen/evtchn.c:599: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:612: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:625: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c: In function 'event_remove_handler':
/usr/src/sys/arch/xen/xen/evtchn.c:669: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:677: error: 'struct evtsource' has no
member named 'ev_lock'
/usr/src/sys/arch/xen/xen/evtchn.c:681: error: 'struct evtsource' has no
member named 'ev_lock'
*** [evtchn.o] Error code 1

nbmake: stopped in /usr/obj/sys/arch/amd64/compile/XEN3_DOMU
1 error

nbmake: stopped in /usr/obj/sys/arch/amd64/compile/XEN3_DOMU

ERROR: Failed to make all in "/usr/src/sys/arch/amd64/compile/obj/XEN3_DOMU"
*** BUILD ABORTED ***

Best regards,

Hugo