Re: [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient

[Boris Ostrovsky <boris.ostrovsky%oracle.com@localhost>]

On 02/23/2015 11:40 AM, Ian Campbell wrote:
> On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote:
> > Currently both of these sysctls make a copy to userspace for each index of
> > various query arrays. We should try to copy whole arrays instead.
> >
> > This requires some changes in sysctl's public data structure, thus bump
> > interface version.
> >
> > Report topology for all present (not just online) cpus.
> >
> > Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact
> > that these are used for CPU topology. Subsequent patch will add support for
> > PCI topology sysctl.
> >
> > Clarify some somments in sysctl.h.
> >
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky%oracle.com@localhost>
> Was there a significant change in v3 which invalidated my tools ack from
> <1421688368.10440.171.camel%citrix.com@localhost>?

Yes, because I merged changes that you ACKed together with (similar) 
changes for numa topology. Which will now have to unmerge because 
various people didn't like it. So I think your ACK will be restored.

> Per-patch changelogs (after the ---) are very helpful for this sort of
> thing.

I should have at least mentioned this in the cover letter, sorry.

-boris