Re: patch: add instrumentation to xen/x86/autoconf.c

[Christoph Badura <bad%bsd.de@localhost>]

On Tue, Jan 22, 2019 at 10:55:17AM +0800, Cherry G. Mathew wrote:
> The advantage is that it can be turned on/off at boot time rather than
> compile time.

Yes, but then you have to remember to boot -d. :-)

Switching this file to aprint_debug* isn't as useful as you might think.
You'd have to go into kern_subr.c:setroot() and rf_netbsdkintf.c at
least.  And you might want to update all the machine dependent code
that sets booted_device, too.  But then you would get temped to get
distracted by all the duplicated and diverged code for boot device
detection...

I'm not going into that part auf Augean stables. :-)  Although cleaning them
out would be worthwhile.

If I do spend more time in this file, I'd rather work on actually
passing the boot device to the kernel.

--chris