Re: merge bouyer-xenpvh to HEAD

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

Compilation with CFLAGS+=XEN fails with:
...
In file included from ./machine/intr.h:3,
                 from /home/sysbuild/src/sys/sys/intr.h:97,
                 from /home/sysbuild/src/sys/sys/mutex.h:174,
                 from ./machine/vmparam.h:42,
                 from /home/sysbuild/src/sys/uvm/uvm_param.h:76,
                 from /home/sysbuild/src/sys/sys/param.h:149,
                 from /tmp/genassym.cYoGAh/assym.c:13:
./x86/intr.h:52:10: fatal error: xen/include/public/xen.h: No such
file or directory
 #include <xen/include/public/xen.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~
...
so probably there is more to it than this.


On Mon, 27 Apr 2020 at 13:26, Manuel Bouyer <bouyer%antioche.eu.org@localhost> wrote:
>
> On Mon, Apr 27, 2020 at 01:36:10PM +0200, Maxime Villard wrote:
> > Don't have time to look at that immediately, but after a very quick glance,
> > it seems clear the problem is in the definition of struct cpu_info. There
> > is an early #ifdef XEN that is true in the kernel but false in the module,
> > leading to serious bugs. Try compiling the module with CFLAGS+=-DXEN, you'll
> > probably see it works.
> >
> > The ifdef should be moved to the end of the structure, like the rest.
>
> If struct cpu_info is part of the module ABI, there's others #ifdef that
> should be removed, isn't it ?
>
> --
> Manuel Bouyer <bouyer%antioche.eu.org@localhost>
>      NetBSD: 26 ans d'experience feront toujours la difference
> --



-- 
----