Re: sys/arch/amd64/conf/XEN_DOM0 v1.194 turns off VGA console

[Emmanuel Dreyfus <manu%netbsd.org@localhost>]

On Wed, Mar 16, 2022 at 02:16:45PM +0530, Mathew, Cherry G. wrote:
> Hi manu, I was surprised to see that the VGA console on dom0 was switched off 
> with -r1.194 of XEN3_DOM0 

I am the culprit. This happened when I tried to move XEN3_DOM0 closer to
GENERIC, as discussed here:
http://mail-index.netbsd.org/port-amd64/2021/09/11/msg003483.html

Most of sys/arch/amd64/conf/XEN3_DOM0 1.193-1.193 is uncomenting
options and devices that were uncomented by GENERIC, but there is
a notable exception, I removed vga by mistake:
#vga*		at pci? dev ? function ?# Needs acpi_md_vbios_reset 
					# in acpi_wakeup.c (!xenpv)

Now I try to add it back, indeed I get:
/whatever/src/tooldir.NetBSD-9.2_STABLE-amd64/bin/x86_64--netbsd-ld: vga_pci.o: in function `vga_pci_resume':
/whatever/src/sys/dev/pci/vga_pci.c:289: undefined reference to `acpi_md_vbios_reset'

acpi_md_vbios_reset is defined in sys/arch/x86/acpi/acpi_wakeup.c
That file is included in the build from sys/arch/x86/conf/files.x86 with a
condition:
file  arch/x86/acpi/acpi_wakeup.c     acpi & !xenpv

At that point, I have trouble to understand how it built before my change.


--
Emmanuel Dreyfus
manu%netbsd.org@localhost