Re: xbd and large sectors

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Fri, Jul 21, 2023 at 01:23:44PM +0200, Manuel Bouyer wrote:
> On Fri, Jul 21, 2023 at 11:48:56AM +0200, Manuel Bouyer wrote:
> > [...]
> > 
> > Reading the linux sources, the xbd driver pass "sectors" directly to
> > set_capacity(), which expects the disk size in 512-byte sectors, so
> > the backend is doing what linux expects, and NetBSD is miscomputing
> > the disk size when doing sectors * sector-size.
> > 
> > A NetBSD dom0 will never report 4k sectors to the guest so we can just fix
> > the frontend, and there's no backward compat issue.
> > 
> > I will commit a fix to HEAD later today.
> 
> Done in xbd_xenbus.c 1.132

Actually 1.133, (1.132 should work but will still display the wrong size)

> Christian can you please test and report if it properly fixes the issue ?
> When I get confirmation that the problem is fixed I'll request a pullup to
> all stable branches
> 
> -- 
> Manuel Bouyer <bouyer%antioche.eu.org@localhost>
>      NetBSD: 26 ans d'experience feront toujours la difference
> --

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--