[src/trunk]: src/usr.bin/make make(1): document possible bug in UpdateTarget ...

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/1f5cc924391e
branches:  trunk
changeset: 1016503:1f5cc924391e
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sun Nov 22 09:48:58 2020 +0000

description:
make(1): document possible bug in UpdateTarget in suffix handling

diffstat:

 usr.bin/make/suff.c |  10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diffs (31 lines):

diff -r f8b5ed5c85b6 -r 1f5cc924391e usr.bin/make/suff.c
--- a/usr.bin/make/suff.c       Sun Nov 22 09:46:37 2020 +0000
+++ b/usr.bin/make/suff.c       Sun Nov 22 09:48:58 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: suff.c,v 1.283 2020/11/22 09:46:37 rillig Exp $        */
+/*     $NetBSD: suff.c,v 1.284 2020/11/22 09:48:58 rillig Exp $        */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -114,7 +114,7 @@
 #include "dir.h"
 
 /*     "@(#)suff.c     8.4 (Berkeley) 3/21/94" */
-MAKE_RCSID("$NetBSD: suff.c,v 1.283 2020/11/22 09:46:37 rillig Exp $");
+MAKE_RCSID("$NetBSD: suff.c,v 1.284 2020/11/22 09:48:58 rillig Exp $");
 
 #define SUFF_DEBUG0(text) DEBUG0(SUFF, text)
 #define SUFF_DEBUG1(fmt, arg1) DEBUG1(SUFF, fmt, arg1)
@@ -667,6 +667,12 @@
        !(target->type & OP_NOTARGET)) {
        *inout_main = target;
        Targ_SetMain(target);
+       /*
+        * XXX: Why could it be a good idea to return TRUE here?
+        * The main task of this function is to turn ordinary nodes into
+        * transformations, no matter whether or not a new .MAIN node
+        * has been found.
+        */
        return TRUE;
     }