Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-9]: src/sys/dev/usb Pull up following revision(s) (requested by j...



details:   https://anonhg.NetBSD.org/src/rev/3c41226a7c45
branches:  netbsd-9
changeset: 372265:3c41226a7c45
user:      martin <martin%NetBSD.org@localhost>
date:      Sat Nov 05 11:19:49 2022 +0000

description:
Pull up following revision(s) (requested by jmcneill in ticket #1550):

        sys/dev/usb/uhidev.c: revision 1.94

Back out r1.82 ("Do not explicitly set the HID Report Protocol upon attach")
due to the regression reported in PR 57031

diffstat:

 sys/dev/usb/uhidev.c |  14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

diffs (36 lines):

diff -r 02956a7adbb3 -r 3c41226a7c45 sys/dev/usb/uhidev.c
--- a/sys/dev/usb/uhidev.c      Thu Oct 27 16:15:57 2022 +0000
+++ b/sys/dev/usb/uhidev.c      Sat Nov 05 11:19:49 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uhidev.c,v 1.75.2.2 2022/02/16 14:36:12 martin Exp $   */
+/*     $NetBSD: uhidev.c,v 1.75.2.3 2022/11/05 11:19:49 martin Exp $   */
 
 /*
  * Copyright (c) 2001, 2012 The NetBSD Foundation, Inc.
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uhidev.c,v 1.75.2.2 2022/02/16 14:36:12 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uhidev.c,v 1.75.2.3 2022/11/05 11:19:49 martin Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -169,16 +169,8 @@
        }
        (void)usbd_set_idle(iface, 0, 0);
 
-#if 0
-       /*
-        * HID 1.11 says we should do this, but the device firmware is
-        * supposed to come up in Report Protocol after reset anyway, and
-        * apparently explicitly requesting it confuses some devices.
-        */
-       if ((usbd_get_quirks(sc->sc_udev)->uq_flags & UQ_NO_SET_PROTO) == 0 &&
-           id->bInterfaceSubClass == UISUBCLASS_BOOT)
+       if ((usbd_get_quirks(sc->sc_udev)->uq_flags & UQ_NO_SET_PROTO) == 0)
                (void)usbd_set_protocol(iface, 1);
-#endif
 
        maxinpktsize = 0;
        sc->sc_iep_addr = sc->sc_oep_addr = -1;



Home | Main Index | Thread Index | Old Index