Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/tests/lib/libc/string PR/57205: Dag-Erling Smørgrav: Add tes...



details:   https://anonhg.NetBSD.org/src/rev/a196370597c7
branches:  trunk
changeset: 373304:a196370597c7
user:      christos <christos%NetBSD.org@localhost>
date:      Mon Jan 30 19:49:49 2023 +0000

description:
PR/57205: Dag-Erling Smørgrav: Add tests strchrnul(3), fix strchr pasto
from strlen.

diffstat:

 tests/lib/libc/string/Makefile      |    3 +-
 tests/lib/libc/string/t_strchr.c    |   12 +-
 tests/lib/libc/string/t_strchrnul.c |  293 ++++++++++++++++++++++++++++++++++++
 3 files changed, 301 insertions(+), 7 deletions(-)

diffs (truncated from 348 to 300 lines):

diff -r 8acd2269f5ec -r a196370597c7 tests/lib/libc/string/Makefile
--- a/tests/lib/libc/string/Makefile    Mon Jan 30 15:22:02 2023 +0000
+++ b/tests/lib/libc/string/Makefile    Mon Jan 30 19:49:49 2023 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2019/12/19 19:19:28 macallan Exp $
+# $NetBSD: Makefile,v 1.13 2023/01/30 19:49:49 christos Exp $
 
 .include <bsd.own.mk>
 
@@ -15,6 +15,7 @@
 TESTS_C+=      t_popcount
 TESTS_C+=      t_strcat
 TESTS_C+=      t_strchr
+TESTS_C+=      t_strchrnul
 TESTS_C+=      t_strcmp
 TESTS_C+=      t_strcoll
 TESTS_C+=      t_strcpy
diff -r 8acd2269f5ec -r a196370597c7 tests/lib/libc/string/t_strchr.c
--- a/tests/lib/libc/string/t_strchr.c  Mon Jan 30 15:22:02 2023 +0000
+++ b/tests/lib/libc/string/t_strchr.c  Mon Jan 30 19:49:49 2023 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: t_strchr.c,v 1.2 2017/01/10 15:34:49 christos Exp $ */
+/* $NetBSD: t_strchr.c,v 1.3 2023/01/30 19:49:49 christos Exp $ */
 
 /*
  * Written by J.T. Conklin <jtc%acorntoolworks.com@localhost>
@@ -247,7 +247,7 @@
        };
 
        dl_handle = dlopen(NULL, RTLD_LAZY);
-       strchr_fn = dlsym(dl_handle, "test_strlen");
+       strchr_fn = dlsym(dl_handle, "test_strchr");
        if (!strchr_fn)
                strchr_fn = strchr;
 
@@ -269,11 +269,11 @@
                        /* Then for the '/' in the strings */
                        verify_strchr(buf + a, '/', t, a);
 
-                       /* check zero extension of char arg */
-                       verify_strchr(buf + a, 0xffffff00 | '/', t, a);
+                       /* check zero extension of char arg */
+                       verify_strchr(buf + a, 0xffffff00 | '/', t, a);
 
-                       /* Replace all the '/' with 0xff */
-                       while ((off = slow_strchr(buf + a, '/')) != NULL)
+                       /* Replace all the '/' with 0xff */
+                       while ((off = slow_strchr(buf + a, '/')) != NULL)
                                *off = 0xff;
 
                        buf[a + len] = 0xff;
diff -r 8acd2269f5ec -r a196370597c7 tests/lib/libc/string/t_strchrnul.c
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tests/lib/libc/string/t_strchrnul.c       Mon Jan 30 19:49:49 2023 +0000
@@ -0,0 +1,293 @@
+/* $NetBSD: t_strchrnul.c,v 1.1 2023/01/30 19:49:49 christos Exp $ */
+
+/*
+ * Written by J.T. Conklin <jtc%acorntoolworks.com@localhost>
+ * Public domain.
+ */
+
+#include <atf-c.h>
+#include <string.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <dlfcn.h>
+
+static char    *slow_strchrnul(char *, int);
+static void     verify_strchrnul(char *, int, unsigned int, unsigned int);
+
+char * (*volatile strchrnul_fn)(const char *, int);
+
+static char *
+slow_strchrnul(char *buf, int ch)
+{
+       unsigned char c = 1;
+
+       ch &= 0xff;
+
+       for (; ; buf++) {
+               c = *buf;
+               if (c == ch || c == 0)
+                       return buf;
+       }
+}
+
+static void
+verify_strchrnul(char *buf, int ch, unsigned int t, unsigned int a)
+{
+       const char *off, *ok_off;
+
+       off = strchrnul_fn(buf, ch);
+       ok_off = slow_strchrnul(buf, ch);
+       if (off == ok_off)
+               return;
+
+       fprintf(stderr, "test_strchrnul(\"%s\", %#x) gave %zd not %zd (test %d, "
+           "alignment %d)\n",
+           buf, ch, off ? off - buf : -1, ok_off ? ok_off - buf : -1, t, a);
+
+       atf_tc_fail("Check stderr for details");
+}
+
+ATF_TC(strchrnul_basic);
+ATF_TC_HEAD(strchrnul_basic, tc)
+{
+
+        atf_tc_set_md_var(tc, "descr", "Test strchrnul(3) results");
+}
+
+ATF_TC_BODY(strchrnul_basic, tc)
+{
+       void *dl_handle;
+       char *off;
+       char buf[32];
+       unsigned int t, a;
+
+       const char *tab[] = {
+               "",
+               "a",
+               "aa",
+               "abc",
+               "abcd",
+               "abcde",
+               "abcdef",
+               "abcdefg",
+               "abcdefgh",
+
+               "/",
+               "//",
+               "/a",
+               "/a/",
+               "/ab",
+               "/ab/",
+               "/abc",
+               "/abc/",
+               "/abcd",
+               "/abcd/",
+               "/abcde",
+               "/abcde/",
+               "/abcdef",
+               "/abcdef/",
+               "/abcdefg",
+               "/abcdefg/",
+               "/abcdefgh",
+               "/abcdefgh/",
+
+               "a/",
+               "a//",
+               "a/a",
+               "a/a/",
+               "a/ab",
+               "a/ab/",
+               "a/abc",
+               "a/abc/",
+               "a/abcd",
+               "a/abcd/",
+               "a/abcde",
+               "a/abcde/",
+               "a/abcdef",
+               "a/abcdef/",
+               "a/abcdefg",
+               "a/abcdefg/",
+               "a/abcdefgh",
+               "a/abcdefgh/",
+
+               "ab/",
+               "ab//",
+               "ab/a",
+               "ab/a/",
+               "ab/ab",
+               "ab/ab/",
+               "ab/abc",
+               "ab/abc/",
+               "ab/abcd",
+               "ab/abcd/",
+               "ab/abcde",
+               "ab/abcde/",
+               "ab/abcdef",
+               "ab/abcdef/",
+               "ab/abcdefg",
+               "ab/abcdefg/",
+               "ab/abcdefgh",
+               "ab/abcdefgh/",
+
+               "abc/",
+               "abc//",
+               "abc/a",
+               "abc/a/",
+               "abc/ab",
+               "abc/ab/",
+               "abc/abc",
+               "abc/abc/",
+               "abc/abcd",
+               "abc/abcd/",
+               "abc/abcde",
+               "abc/abcde/",
+               "abc/abcdef",
+               "abc/abcdef/",
+               "abc/abcdefg",
+               "abc/abcdefg/",
+               "abc/abcdefgh",
+               "abc/abcdefgh/",
+
+               "abcd/",
+               "abcd//",
+               "abcd/a",
+               "abcd/a/",
+               "abcd/ab",
+               "abcd/ab/",
+               "abcd/abc",
+               "abcd/abc/",
+               "abcd/abcd",
+               "abcd/abcd/",
+               "abcd/abcde",
+               "abcd/abcde/",
+               "abcd/abcdef",
+               "abcd/abcdef/",
+               "abcd/abcdefg",
+               "abcd/abcdefg/",
+               "abcd/abcdefgh",
+               "abcd/abcdefgh/",
+
+               "abcde/",
+               "abcde//",
+               "abcde/a",
+               "abcde/a/",
+               "abcde/ab",
+               "abcde/ab/",
+               "abcde/abc",
+               "abcde/abc/",
+               "abcde/abcd",
+               "abcde/abcd/",
+               "abcde/abcde",
+               "abcde/abcde/",
+               "abcde/abcdef",
+               "abcde/abcdef/",
+               "abcde/abcdefg",
+               "abcde/abcdefg/",
+               "abcde/abcdefgh",
+               "abcde/abcdefgh/",
+
+               "abcdef/",
+               "abcdef//",
+               "abcdef/a",
+               "abcdef/a/",
+               "abcdef/ab",
+               "abcdef/ab/",
+               "abcdef/abc",
+               "abcdef/abc/",
+               "abcdef/abcd",
+               "abcdef/abcd/",
+               "abcdef/abcde",
+               "abcdef/abcde/",
+               "abcdef/abcdef",
+               "abcdef/abcdef/",
+               "abcdef/abcdefg",
+               "abcdef/abcdefg/",
+               "abcdef/abcdefgh",
+               "abcdef/abcdefgh/",
+
+               "abcdefg/",
+               "abcdefg//",
+               "abcdefg/a",
+               "abcdefg/a/",
+               "abcdefg/ab",
+               "abcdefg/ab/",
+               "abcdefg/abc",
+               "abcdefg/abc/",
+               "abcdefg/abcd",
+               "abcdefg/abcd/",
+               "abcdefg/abcde",
+               "abcdefg/abcde/",
+               "abcdefg/abcdef",
+               "abcdefg/abcdef/",
+               "abcdefg/abcdefg",
+               "abcdefg/abcdefg/",
+               "abcdefg/abcdefgh",
+               "abcdefg/abcdefgh/",
+
+               "abcdefgh/",
+               "abcdefgh//",
+               "abcdefgh/a",
+               "abcdefgh/a/",
+               "abcdefgh/ab",
+               "abcdefgh/ab/",
+               "abcdefgh/abc",
+               "abcdefgh/abc/",
+               "abcdefgh/abcd",
+               "abcdefgh/abcd/",
+               "abcdefgh/abcde",
+               "abcdefgh/abcde/",
+               "abcdefgh/abcdef",
+               "abcdefgh/abcdef/",
+               "abcdefgh/abcdefg",
+               "abcdefgh/abcdefg/",
+               "abcdefgh/abcdefgh",
+               "abcdefgh/abcdefgh/",



Home | Main Index | Thread Index | Old Index