Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev ipmi(4): Notify config_pending_decr when ready, not ...



details:   https://anonhg.NetBSD.org/src/rev/5da9215bc402
branches:  trunk
changeset: 379691:5da9215bc402
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Mon Jun 14 22:00:10 2021 +0000

description:
ipmi(4): Notify config_pending_decr when ready, not when dying.

Should fix hang at boot.

diffstat:

 sys/dev/ipmi.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (35 lines):

diff -r b2a7ffbd0598 -r 5da9215bc402 sys/dev/ipmi.c
--- a/sys/dev/ipmi.c    Mon Jun 14 18:44:53 2021 +0000
+++ b/sys/dev/ipmi.c    Mon Jun 14 22:00:10 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ipmi.c,v 1.7 2021/06/12 12:15:43 riastradh Exp $ */
+/*     $NetBSD: ipmi.c,v 1.8 2021/06/14 22:00:10 riastradh Exp $ */
 
 /*
  * Copyright (c) 2019 Michael van Elst
@@ -76,7 +76,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ipmi.c,v 1.7 2021/06/12 12:15:43 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ipmi.c,v 1.8 2021/06/14 22:00:10 riastradh Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>
@@ -2090,6 +2090,8 @@ ipmi_thread(void *cookie)
        if (!pmf_device_register(self, ipmi_suspend, NULL))
                 aprint_error_dev(self, "couldn't establish a power handler\n");
 
+       config_pending_decr(self);
+
        mutex_enter(&sc->sc_poll_mtx);
        while (sc->sc_thread_running) {
                while (sc->sc_mode == IPMI_MODE_COMMAND)
@@ -2108,7 +2110,6 @@ ipmi_thread(void *cookie)
                    SENSOR_REFRESH_RATE);
        }
        mutex_exit(&sc->sc_poll_mtx);
-       config_pending_decr(self);
        kthread_exit(0);
 }
 



Home | Main Index | Thread Index | Old Index