Re: NetBSD master CVS tree commits

[ws%tools.de@localhost (Wolfgang Solfrank)]

Hi,

While I'm not sure that I approve of the other changes you did recently
(e.g. I consider (almost?) all uses of [hn]to[nh]* that actually need them
as a function are in error, especially in the kernel), unfortunately I don't
have time currently to further dig into them :-(.

This one however caught my particular attention:

> mycroft
> Sat Feb 21 23:42:31 PST 1998
> Update of /cvsroot/src/sys/arch/powerpc/stand/ofwboot
> In directory nb00:/tmp/cvs-serv1313
> 
> Modified Files:
>       Locore.c alloc.c boot.c net.c netif_of.c ofdev.c openfirm.h 
> Log Message:
> Clean up #include paths.
> Copy prom2boot() from kernel source.
> rename _rtt() to OF_exit(), and add a _rtt() that calls it.

Where did you copy prom2boot from?  A find of the complete sys source tree
didn't reveal any prom2boot function other than the one in boot.c.

Anyway, your modification is wrong.  The old version effectively did something
similar (ignoring error handling) to: *strrchr(arg, ':') = 0; while your
version does: *strchr(arg, ':') = 0;  Note the missing second 'r' :-).

The idea is to strip off any arguments the boot code gave to the last component
of the boot path (might be the filename of the booted file).  Since any
component of the boot path might have arguments, your version could strip way
too much from the boot path.

I suggest you back out this change.

Ciao,
Wolfgang
-- 
ws%TooLs.DE@localhost     (Wolfgang Solfrank, TooLs GmbH)       +49-228-985800