Re: CVS commit: basesrc - telnet

[Dave Sainty <dave%dtsp.co.nz@localhost>]

David Brownlee writes:

> Module Name:  basesrc
> Committed By: abs
> Date:         Wed Jul 28 06:35:16 UTC 1999
> 
> Modified Files:
>       basesrc/usr.bin/telnet: commands.c externs.h main.c telnet.1 telnet.c
> 
> Log Message:
> Add -N option (numeric host address) - idea taken from FreeBSD.
> Fix bug where -E8 would still pick up 0xFF as escape (again from FreeBSD)

This sounds strange.  Even when binary mode has been negotiated, 0xff
still needs to be treated as an escape.  Binary mode doesn't disable
telnet protocol encapsulation of the data, it just modifies the
interpretation of the data.

There should be escape handling for 0xff in both directions regardless
of whether binary mode is on or off...

Is this change consistent with that?

Cheers,

Dave