Re: CVS commit: basesrc

[M Graff <explorer%flame.org@localhost>]

Luke Mewburn <lukem%goanna.cs.rmit.edu.au@localhost> writes:

> > If a function is called with bogus args, printing on the screen "bogus
> > args" is wrong.  This would have normally caused a crash, and it
> > should still do so with the usual _DIAGASSERT(s != NULL) thing.
> 
> I thought I rolled back that stuff...

You did, I posted after being gone for a week.  Sorry.

> > The whole point to the suggestion I made about argument checking was
> > to catch programmer errors by supplying the file/line and a core dump,
> > not to ignore errors and continue.  We're not linux here.  :)
> 
> So, Core Dumps are for Real Men Who Use BSD? So much for touting
> ourselves as a robust system...

I believe that hiding errors via return codes and errno settings will
only create problems.  It is better that the application crash as soon
as such an error is detected rather than try to plod along.

> Anyway, I got sick of the complaints. This stuff was rolled back.
> Obviously I missed a couple of things.

No, I didn't read all 400+ change logs before I posted.  Again, sorry.

--Michael