Re: CVS commit: syssrc

[Jaromir Dolecek <dolecek%ics.muni.cz@localhost>]

Matthias Scheler wrote:
> Module Name:  syssrc
> Committed By: tron
> Date:         Sun Dec  5 15:53:38 UTC 1999
> 
> Modified Files:
>       syssrc/sys/kern: kern_allocsys.c
> 
> Log Message:
> Correct calculation of buffer pages if BUFCACHE is defined. Patch supplied
> by kern/8954 by URA Hiroshi.

Note that there is a possible integer overflow if physmem * BUFSIZE
is bigger than an (unsigned) int may hold. gcc handles the case
ok even for ints, but e.g. SGI cc doesn't. I tried also SunPROcc so far
and that one doesn't right thing even when the variables
are wide enough (possibly bug in compiler, who knows). I'm investigating
whether some casting would make the code work OK even on non-gcc
compilers.

Jaromir
-- 
Jaromir Dolecek <jdolecek%NetBSD.org@localhost>      
http://www.ics.muni.cz/~dolecek/
@@@@  Wanna a real operating system ? Go and get NetBSD, damn it!  @@@@