Re: CVS commit: syssrc (kern/9697)

[John Hawkinson <jhawk%MIT.EDU@localhost>]

I'm not terribly happy with this.

I'm not convinced that it is appropriate for this message not to appear
in the default case. For most filesystems, the message ocurrs
once as the partition grows or shrinks, and most partitions tend
to grow but not shrink.

I have always presumed that for the case of partitions that
flipflop between time and space optimizations, that meant that
the filesystem should be tuned with tunefs -o, or perhaps tunefs -m.
Or perhaps alternately that the algorithm needed to be adjusted
such that it did not fail in this way on such partitions.

It's not clear to me whether the rapid flipflopping between
optimizations does constitute a "failure" or not.

AFS cache partitions definitely have the tendancy to flipflip a lot,
though, and there are enough of them around that they probably are a
legitimate special case.



Regardless of that, conditionalization on DEBUG really
doesn't seem right. It's defined as "miscellaneous kernel debugging",
which this really is not. I would propose "options FFSVERBOSE"
instead.

--jhawk
  (who gets annoyed by these messages, too...)

| From: Jaromir Dolecek <dolecek%ics.muni.cz@localhost>
| Message-Id: <200003290900.LAA02067%jdolecek.per4mance.cz@localhost>
| Subject: Re: CVS commit: syssrc
| In-Reply-To: <200003290849.RAA00539%edge.sky.yamashina.kyoto.jp@localhost> 
from Takahiro Kambe at "Mar 29, 2000 05:49:53 pm"
| To: taca%sky.yamashina.kyoto.jp@localhost (Takahiro Kambe)
| Date: Wed, 29 Mar 2000 11:00:08 +0200 (MEST)
| Cc: source-changes%netbsd.org@localhost
| 
| Takahiro Kambe wrote:
| > > Modified Files:
| > >   syssrc/sys/ufs/ffs: ffs_alloc.c
| > > 
| > > Log Message:
| > > Log the optimization changes only if DEBUG
| > Is it more suitable with DIAGNOSTIC not DEBUG?
| 
| I though a while about throwing the message out completely. I don't
| think that the message is actually helpful or informative. It's
| like plenty of other potentially usable debug messages. DIAGNOSTIC
| is IMHO for adding extra consistency checking and such - this message
| is just noisy, doesn't show any real problem.
...