Subject: Re: CVS commit: basesrc
To: Lennart Augustsson <lennart@mail.augustsson.net>
From: Luke Mewburn <lukem@wasabisystems.com>
List: source-changes
Date: 01/11/2001 16:32:58
On Thu, Jan 11, 2001 at 12:16:47AM -0500, Lennart Augustsson wrote:
> Luke Mewburn wrote:
>
> > > > Log Message:
> > > > use explicit name rather than __progname in openlog
> > >
> > > What's the point of this?
> >
> > because we're very inconsistent in the tree about whether we use
> > __progname or the explicit name, with the explicit name seeming to
> > have more use.
>
> IMO, changing from __progname to and explicit name is a big step
> backwards. I wish we won't do this.
So, I just had look at the openlog() usage in the source tree, and
this is what I discovered:
Programs changed from __progname (according to "cvs diff -D2001/01/09 -Dnow")
sbin/wdogctl
usr.sbin/apmd
usr.sbin/inetd
usr.sbin/mop/mopchk
usr.sbin/mop/mopd
usr.sbin/mop/mopprobe
usr.sbin/mop/moptrace
usr.sbin/rarpd
usr.sbin/rbootd
usr.sbin/rpc.bootparamd
usr.sbin/ypserv
usr.sbin/ypxfer
All programs calling openlog:
crypto/dist/heimdal/appl/ftp/ftpd
crypto/dist/heimdal/appl/login
crypto/dist/heimdal/lib/auth/pam
crypto/dist/krb4/appl/bsd
crypto/dist/krb4/appl/ftp/ftpd
crypto/dist/krb4/lib/auth/pam
dist/bind/bin/irpd
dist/bind/bin/named
dist/ipf/FWTK
dist/ntp/adjtimed
dist/ntp/ntpd
dist/ntp/ntpdate
dist/ntp/parseutil
games/hunt/huntd
gnu/dist/sendmail/mail.local
gnu/dist/sendmail/sendmail
gnu/dist/sendmail/smrsh
gnu/dist/sendmail/vacation
libexec/atrun
libexec/comsat
libexec/fingerd
libexec/ftpd
libexec/getty
libexec/identd
libexec/lfs_cleanerd
libexec/mail.local
libexec/rexecd
libexec/rlogind
libexec/rpc.rquotad
libexec/rpc.rstatd
libexec/rpc.rusersd
libexec/rpc.rwalld
libexec/rpc.sprayd
libexec/rshd
libexec/talkd
libexec/telnetd
libexec/tftpd
libexec/uucpd
sbin/init
sbin/mount_nfs
sbin/mount_portal
sbin/reboot
sbin/routed
sbin/savecore
sbin/shutdown
sbin/wdogctl
usr.bin/login
usr.bin/su
usr.bin/vacation
usr.sbin/altq/altqd
usr.sbin/apmd
usr.sbin/inetd
usr.sbin/isdn/isdnd
usr.sbin/lpr/lpc
usr.sbin/lpr/lpd
usr.sbin/lpr/lpq
usr.sbin/lpr/lpr
usr.sbin/lpr/lprm
usr.sbin/mopd/mopchk
usr.sbin/mopd/mopd
usr.sbin/mopd/mopprobe
usr.sbin/mopd/moptrace
usr.sbin/mountd
usr.sbin/mrouted
usr.sbin/nfsd
usr.sbin/pim6dd
usr.sbin/pim6sd
usr.sbin/pppd/chat
usr.sbin/pppd/pppd
usr.sbin/rarpd
usr.sbin/rbootd
usr.sbin/rpc.bootparamd
usr.sbin/rpc.lockd
usr.sbin/rpc.statd
usr.sbin/rpcbind
usr.sbin/rtadvd
usr.sbin/rwhod
usr.sbin/sesd/srcs
usr.sbin/timed/timed
usr.sbin/timed/timedc
usr.sbin/ypbind
usr.sbin/ypserv/ypserv
usr.sbin/ypserv/ypxfr
I don't think I change the 13 applications that were using __progname
as the ident arg to openlog() which I changed to being a static string
back to __progname, and then also change the other 69 applications
that were using a static ident to __progname.
That seems like a backward step to me, especially in the portability
stakes.