Subject: Re: CVS commit: syssrc
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Aymeric Vincent <Aymeric.Vincent@labri.u-bordeaux.fr>
List: source-changes
Date: 01/13/2001 11:23:45
Izumi Tsutsui <tsutsui@ceres.dti.ne.jp> writes:
> > Make this compile again: we don't need to initialize PAGE_SIZE and friends
> > since they are now (preprocessor) constants.
>
> PAGE_SIZE was defined as uvmexp.pagesize before.
> Shouldn't it be initialized to NBPG? I guess NBPG is
> 8192 on amiga, not DEFAULT_PAGE_SIZE (==4096).
Jason changed PAGE_SIZE into constants on Nov, 14th and it looks like
PAGE_SIZE is 8K on the Amiga (see amiga/include/vmparam.h).
I just made the amiga port compile again yesterday, and trying to
write a value into a constant looked like a bad thing. ;) I didn't
look thoroughly at the issue.
Jason, comments?
regards,
Aymeric