Re: CVS commit: syssrc/sys/dev/pci

[Chuck Silvers <chuq%chuq.com@localhost>]

hi,

this driver doesn't compile with the GENERIC config:

../../../../dev/pci/emuxki.c:391: warning: too many arguments for format

the offending line is:

                printf(", couldn't establish interrupt", sc->sc_dev.dv_xname);

I'm curious why -Werror didn't catch this for you?
if you've removed this flag from your local tree,
you really ought to put it back to help yourself
avoid checking in code that doesn't compile for others.

-Chuck


On Wed, Oct 17, 2001 at 09:39:42PM +0300, Jaromir Dolecek wrote:
> 
> Module Name:  syssrc
> Committed By: jdolecek
> Date:         Wed Oct 17 18:39:42 UTC 2001
> 
> Modified Files:
>       syssrc/sys/dev/pci: files.pci
> Added Files:
>       syssrc/sys/dev/pci: emuxki.c emuxkireg.h emuxkivar.h
> 
> Log Message:
> Add driver for Creative Labs SBLive! EMU10000, possibly also PCI512.
> Written by Yannick Montulet (thanks!), with only couple minor touches by me.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r0 -r1.1 syssrc/sys/dev/pci/emuxki.c \
>     syssrc/sys/dev/pci/emuxkireg.h syssrc/sys/dev/pci/emuxkivar.h
> cvs rdiff -r1.141 -r1.142 syssrc/sys/dev/pci/files.pci
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.